Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2999943002: Migrated test block 168 to Dart 2.0. (Closed)

Created:
3 years, 4 months ago by bkonyi
Modified:
3 years, 4 months ago
Reviewers:
Bob Nystrom, jcollins
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrated test block 168 to Dart 2.0. This block felt trickier than others, mostly due to random errors that I wasn't able to find a cause for. Tests that I'm uncertain about are: -first_regression_test -future_timeout_test -future_or_bad_type_test/implements These all have status entries to prevent failures, but I think these tests need another set of eyes. BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/42d354c91dcd69fd468134fc9a21275f4628b7a6

Patch Set 1 #

Total comments: 3

Patch Set 2 : Removed async/future_test.dartm #

Patch Set 3 : Fixed async/future_test.dart #

Total comments: 28

Patch Set 4 : Fixed package:test crash related issues, addressed Bob's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -5086 lines) Patch
D tests/lib/async/catch_errors_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/lib/async/dart2js_uncaught_error_test.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D tests/lib/async/event_helper.dart View 1 chunk +0 lines, -184 lines 0 comments Download
D tests/lib/async/first_regression_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/lib/async/future_constructor2_test.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D tests/lib/async/future_constructor_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D tests/lib/async/future_delayed_error_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D tests/lib/async/future_foreach_test.dart View 1 chunk +0 lines, -111 lines 0 comments Download
D tests/lib/async/future_microtask_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D tests/lib/async/future_or_bad_type_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/lib/async/future_or_non_strong_test.dart View 1 chunk +0 lines, -111 lines 0 comments Download
D tests/lib/async/future_or_only_in_async_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/lib/async/future_or_strong_test.dart View 1 chunk +0 lines, -119 lines 0 comments Download
D tests/lib/async/future_test.dart View 1 chunk +0 lines, -1240 lines 0 comments Download
D tests/lib/async/future_timeout_test.dart View 1 chunk +0 lines, -200 lines 0 comments Download
D tests/lib/async/future_value_chain2_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/lib/async/future_value_chain3_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/lib/async/future_value_chain4_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/lib/async/future_value_chain_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
M tests/lib/lib.status View 6 chunks +0 lines, -11 lines 0 comments Download
M tests/lib_2/async/catch_errors.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/lib_2/async/catch_errors_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/dart2js_uncaught_error_test.dart View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A + tests/lib_2/async/event_helper.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/first_regression_test.dart View 1 2 3 2 chunks +5 lines, -10 lines 0 comments Download
A + tests/lib_2/async/future_constructor2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/future_constructor_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/future_delayed_error_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/future_foreach_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/future_microtask_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/lib_2/async/future_or_bad_type_test.dart View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
A + tests/lib_2/async/future_or_only_in_async_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/lib_2/async/future_or_strong_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/future_test.dart View 1 2 10 chunks +23 lines, -19 lines 0 comments Download
A + tests/lib_2/async/future_timeout_test.dart View 1 2 3 4 chunks +114 lines, -86 lines 0 comments Download
A + tests/lib_2/async/future_value_chain2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/future_value_chain3_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/future_value_chain4_test.dart View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
A + tests/lib_2/async/future_value_chain_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/futures_test.dart View 1 2 3 12 chunks +35 lines, -35 lines 0 comments Download
M tests/lib_2/lib_2.status View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M tests/lib_2/lib_2_dart2js.status View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
A tests/lib_2/lib_2_dartdevc.status View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
A + tests/lib_2/lib_2_kernel.status View 1 chunk +5 lines, -0 lines 0 comments Download
A + tests/lib_2/lib_2_precompiled.status View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
A tests/lib_2/lib_2_vm.status View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
D tests/lib_strong/async/catch_errors_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/lib_strong/async/dart2js_uncaught_error_test.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D tests/lib_strong/async/event_helper.dart View 1 chunk +0 lines, -184 lines 0 comments Download
D tests/lib_strong/async/first_regression_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/lib_strong/async/future_constructor2_test.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D tests/lib_strong/async/future_constructor_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D tests/lib_strong/async/future_delayed_error_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D tests/lib_strong/async/future_microtask_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D tests/lib_strong/async/future_or_bad_type_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/lib_strong/async/future_or_non_strong_test.dart View 1 chunk +0 lines, -111 lines 0 comments Download
D tests/lib_strong/async/future_or_only_in_async_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/lib_strong/async/future_or_strong_test.dart View 1 chunk +0 lines, -119 lines 0 comments Download
D tests/lib_strong/async/future_test.dart View 1 chunk +0 lines, -1240 lines 0 comments Download
D tests/lib_strong/async/future_timeout_test.dart View 1 chunk +0 lines, -200 lines 0 comments Download
D tests/lib_strong/async/future_value_chain2_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/lib_strong/async/future_value_chain3_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/lib_strong/async/future_value_chain4_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/lib_strong/async/future_value_chain_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/lib_strong/async/futures_test.dart View 1 chunk +0 lines, -268 lines 0 comments Download
M tests/lib_strong/lib_strong.status View 2 chunks +0 lines, -14 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
bkonyi
This was a tricky block with a couple of tests I was unsure of (see ...
3 years, 4 months ago (2017-08-14 23:33:14 UTC) #2
Bob Nystrom
https://codereview.chromium.org/2999943002/diff/40001/tests/lib_2/async/first_regression_test.dart File tests/lib_2/async/first_regression_test.dart (right): https://codereview.chromium.org/2999943002/diff/40001/tests/lib_2/async/first_regression_test.dart#newcode10 tests/lib_2/async/first_regression_test.dart:10: import 'package:test/test.dart'; Is it possible to move this off ...
3 years, 4 months ago (2017-08-16 22:27:21 UTC) #3
bkonyi
Issues with package:test resolved + comments addressed. PTAL :) https://codereview.chromium.org/2999943002/diff/40001/tests/lib_2/async/first_regression_test.dart File tests/lib_2/async/first_regression_test.dart (right): https://codereview.chromium.org/2999943002/diff/40001/tests/lib_2/async/first_regression_test.dart#newcode10 tests/lib_2/async/first_regression_test.dart:10: ...
3 years, 4 months ago (2017-08-16 23:44:14 UTC) #4
Bob Nystrom
LGTM! https://codereview.chromium.org/2999943002/diff/40001/tests/lib_2/async/future_or_bad_type_test.dart File tests/lib_2/async/future_or_bad_type_test.dart (right): https://codereview.chromium.org/2999943002/diff/40001/tests/lib_2/async/future_or_bad_type_test.dart#newcode15 tests/lib_2/async/future_or_bad_type_test.dart:15: implements FutureOr<int> //# implements: ok On 2017/08/16 23:44:13, ...
3 years, 4 months ago (2017-08-16 23:47:32 UTC) #5
bkonyi
3 years, 4 months ago (2017-08-21 07:59:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
42d354c91dcd69fd468134fc9a21275f4628b7a6.

Powered by Google App Engine
This is Rietveld 408576698