Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1063)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2993213003: Migrated test block 167 to Dart 2.0. (Closed)

Created:
3 years, 4 months ago by bkonyi
Modified:
3 years, 4 months ago
Reviewers:
jcollins
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrated test block 167 to Dart 2.0. No manual work required for this block. BUG= R=jcollins@google.com Committed: https://github.com/dart-lang/sdk/commit/55612ef10c1cc712f446807933816f810fbd7242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -1250 lines) Patch
D tests/lib/async/catch_errors18_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D tests/lib/async/catch_errors19_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D tests/lib/async/catch_errors20_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D tests/lib/async/catch_errors21_test.dart View 1 chunk +0 lines, -55 lines 0 comments Download
D tests/lib/async/catch_errors22_test.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D tests/lib/async/catch_errors23_test.dart View 1 chunk +0 lines, -79 lines 0 comments Download
D tests/lib/async/catch_errors24_test.dart View 1 chunk +0 lines, -79 lines 0 comments Download
D tests/lib/async/catch_errors25_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D tests/lib/async/catch_errors26_test.dart View 1 chunk +0 lines, -74 lines 0 comments Download
D tests/lib/async/catch_errors27_test.dart View 1 chunk +0 lines, -79 lines 0 comments Download
D tests/lib/async/catch_errors28_test.dart View 1 chunk +0 lines, -49 lines 0 comments Download
M tests/lib/lib.status View 2 chunks +0 lines, -5 lines 0 comments Download
A tests/lib_2/async/catch_errors.dart View 1 chunk +55 lines, -0 lines 0 comments Download
A + tests/lib_2/async/catch_errors18_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/catch_errors19_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/catch_errors20_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/catch_errors21_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/catch_errors22_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/catch_errors23_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/catch_errors24_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/catch_errors25_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/catch_errors26_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/catch_errors27_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/catch_errors28_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/lib_2/lib_2_dart2js.status View 1 chunk +10 lines, -0 lines 0 comments Download
D tests/lib_strong/async/catch_errors18_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D tests/lib_strong/async/catch_errors19_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D tests/lib_strong/async/catch_errors20_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D tests/lib_strong/async/catch_errors21_test.dart View 1 chunk +0 lines, -55 lines 0 comments Download
D tests/lib_strong/async/catch_errors22_test.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D tests/lib_strong/async/catch_errors23_test.dart View 1 chunk +0 lines, -79 lines 0 comments Download
D tests/lib_strong/async/catch_errors24_test.dart View 1 chunk +0 lines, -79 lines 0 comments Download
D tests/lib_strong/async/catch_errors25_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D tests/lib_strong/async/catch_errors26_test.dart View 1 chunk +0 lines, -74 lines 0 comments Download
D tests/lib_strong/async/catch_errors27_test.dart View 1 chunk +0 lines, -79 lines 0 comments Download
D tests/lib_strong/async/catch_errors28_test.dart View 1 chunk +0 lines, -49 lines 0 comments Download

Dependent Patchsets:

Issue 2999943002 Patch 1
Issue 2999943002 Patch 20001
Issue 2999943002 Patch 40001
Issue 2999943002 Patch 60001

Messages

Total messages: 5 (2 generated)
bkonyi
3 years, 4 months ago (2017-08-07 21:58:29 UTC) #2
jcollins
lgtm
3 years, 4 months ago (2017-08-08 15:45:21 UTC) #3
bkonyi
3 years, 4 months ago (2017-08-17 19:42:44 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
55612ef10c1cc712f446807933816f810fbd7242.

Powered by Google App Engine
This is Rietveld 408576698