tests/lib_2/lib_2.status - Issue 2999943002: Migrated test block 168 to Dart 2.0.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests/lib_2/lib_2.status

Issue 2999943002: Migrated test block 168 to Dart 2.0. (Closed)

Patch Set: Fixed async/future_test.dart Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file	1 # Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file

2 # for details. All rights reserved. Use of this source code is governed by a	2 # for details. All rights reserved. Use of this source code is governed by a

3 # BSD-style license that can be found in the LICENSE file.	3 # BSD-style license that can be found in the LICENSE file.

	4

	5 [ $strong && $compiler != dart2analyzer && $compiler != dartdevc ]
	Bob Nystrom 2017/08/16 22:27:20 Is this basically to match "strong mode on the VM" Is this basically to match "strong mode on the VM"? If so, it would be good make that more explicit. Maybe "$runtime == vm" and move it into that status file? bkonyi 2017/08/16 23:44:13 Done. Show quoted text On 2017/08/16 22:27:20, Bob Nystrom wrote: > Is this basically to match "strong mode on the VM"? If so, it would be good make > that more explicit. Maybe "$runtime == vm" and move it into that status file? Done.
	6 # async/future_or_bad_type_test/implements: CompileTimeError
	Bob Nystrom 2017/08/16 22:27:20 Should this be commented out? Should this be commented out? bkonyi 2017/08/16 23:44:13 This was temporary since adding that line actually Show quoted text On 2017/08/16 22:27:20, Bob Nystrom wrote: > Should this be commented out? This was temporary since adding that line actually caused failures (this was one of the tests I was having issues with). I've since fixed this.
	7 async/future_or_only_in_async_test/00: MissingCompileTimeError

	8

	9 [ !$strong && $compiler != dartdevc && $checked ]

	10 async/future_or_bad_type_test/implements: CompileTimeError

	11 async/future_or_only_in_async_test/00: MissingCompileTimeError

	12

	13 [ !$strong && !$checked]

	14 async/future_or_bad_type_test/implements: CompileTimeError

	15 async/future_or_only_in_async_test/00: MissingCompileTimeError

	16

	17 [ $compiler != dart2js ]

	18 async/dart2js_uncaught_error_test: Skip # JS-integration only test
	Bob Nystrom 2017/08/16 22:27:20 Ah, the migration script doesn't handle "!=" (beca Ah, the migration script doesn't handle "!=" (because it's not always clear what those mean). In this case, it's a dart2js-related test, so I would move this to lib_dart2js.status. Even better would be to move it out of lib_2/ entirely into compiler/dart2js, but that's more of a pain. Maybe add a TODO in the test to do that? bkonyi 2017/08/16 23:44:13 Added the TODO. Done. Show quoted text On 2017/08/16 22:27:20, Bob Nystrom wrote: > Ah, the migration script doesn't handle "!=" (because it's not always clear what > those mean). In this case, it's a dart2js-related test, so I would move this to > lib_dart2js.status. > > Even better would be to move it out of lib_2/ entirely into compiler/dart2js, > but that's more of a pain. Maybe add a TODO in the test to do that? Added the TODO. Done.
	19

	20

OLD	NEW

« tests/lib_2/async/future_value_chain4_test.dart ('K') | « tests/lib_2/async/futures_test.dart ('k') | tests/lib_2/lib_2_dart2js.status » ('j') | tests/lib_2/lib_2_dart2js.status » ('J')