Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2999923002: Revert of Allow creating GLImage-backed textures with glTexStorage2D. (Closed)

Created:
3 years, 4 months ago by jbauman
Modified:
3 years, 4 months ago
CC:
chromium-reviews, piman+watch_chromium.org, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow creating GLImage-backed textures with glTexStorage2D. (patchset #7 id:120001 of https://codereview.chromium.org/2945673002/ ) Reason for revert: Caused increase in memory usage (maybe leak) on media.tough_video_cases_tbmv2 BUG=755136 Original issue's description: > Allow creating GLImage-backed textures with glTexStorage2D. > > Add a GL_TEXTURE_BUFFER_USAGE_CHROMIUM TexParameter that can be > specified before glTexStorage2D so it will create a texture that's > backed by an anonymous GLImage. The compositor will use this for > raster buffers that are drawn into using the GPU rasterizer (and thus > don't need to be mapped) and are used with overlays. This will save a > synchronous IPC through the browser into the GPU I/O thread when > creating them. > > BUG= > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2945673002 > Cr-Commit-Position: refs/heads/master@{#493302} > Committed: https://chromium.googlesource.com/chromium/src/+/5b05b9032e67ea278ae3a3d1eb2731d1dcdb68c5 TBR=ericrk@chromium.org,zmo@chromium.org,dcheng@chromium.org,dcheng@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2999923002 Cr-Commit-Position: refs/heads/master@{#494138} Committed: https://chromium.googlesource.com/chromium/src/+/20bcdb14c7a6f0801522d23693f530d4f224d727

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -446 lines) Patch
M cc/resources/resource_provider.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M cc/resources/resource_provider.cc View 1 5 chunks +12 lines, -33 lines 0 comments Download
M cc/resources/resource_provider_unittest.cc View 1 9 chunks +5 lines, -64 lines 0 comments Download
M cc/test/test_web_graphics_context_3d.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
D gpu/GLES2/extensions/CHROMIUM/CHROMIUM_texture_buffer.txt View 1 chunk +0 lines, -128 lines 0 comments Download
M gpu/GLES2/gl2extchromium.h View 1 1 chunk +0 lines, -8 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 1 chunk +0 lines, -8 lines 0 comments Download
M gpu/command_buffer/common/capabilities.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_autogen.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 1 2 chunks +0 lines, -16 lines 0 comments Download
M gpu/command_buffer/service/feature_info.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 4 chunks +1 line, -66 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_autogen.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 1 1 chunk +0 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/image_factory.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/image_factory.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 3 chunks +1 line, -10 lines 0 comments Download
M gpu/command_buffer/tests/gl_texture_storage_unittest.cc View 1 4 chunks +0 lines, -29 lines 0 comments Download
M gpu/command_buffer/tests/texture_image_factory.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/tests/texture_image_factory.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M gpu/ipc/common/gpu_command_buffer_traits_multi.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M gpu/ipc/service/gpu_memory_buffer_factory_io_surface.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M gpu/ipc/service/gpu_memory_buffer_factory_io_surface.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download
M ui/gl/gl_bindings.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gl/gl_image.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ui/gl/gl_image.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gl/gl_image_io_surface.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_image_io_surface.mm View 1 2 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
jbauman
Created Revert of Allow creating GLImage-backed textures with glTexStorage2D.
3 years, 4 months ago (2017-08-14 16:52:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2999923002/1
3 years, 4 months ago (2017-08-14 16:52:26 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/328861)
3 years, 4 months ago (2017-08-14 16:56:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2999923002/450001
3 years, 4 months ago (2017-08-14 17:43:17 UTC) #11
commit-bot: I haz the power
3 years, 4 months ago (2017-08-14 19:45:09 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:450001) as
https://chromium.googlesource.com/chromium/src/+/20bcdb14c7a6f0801522d23693f5...

Powered by Google App Engine
This is Rietveld 408576698