Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 2999493002: Rename deployment manifests back to source manifests. (Closed)

Created:
3 years, 4 months ago by iannucci
Modified:
3 years, 4 months ago
Reviewers:
dnj, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Rename deployment manifests back to source manifests. Not only was the previous commit message wrong, but we wanted to call them source manifests anyway. R=dnj@chromium.org, hinoka@chromium.org BUG=468053 Review-Url: https://codereview.chromium.org/2999493002 Committed: https://github.com/luci/luci-go/commit/678bb0eefa62cbad33363d38ef4ccc8567c38a4e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -89 lines) Patch
M common/proto/milo/annotations.proto View 1 chunk +1 line, -1 line 0 comments Download
M common/proto/milo/annotations.pb.go View 3 chunks +71 lines, -71 lines 0 comments Download
M logdog/client/annotee/annotation/annotation.go View 1 chunk +9 lines, -9 lines 0 comments Download
M logdog/client/annotee/annotation/test_data/coverage.annotations.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M logdog/client/annotee/annotation/test_expectations/coverage_base.proto.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
iannucci
3 years, 4 months ago (2017-08-05 01:47:16 UTC) #1
dnj
lgtm
3 years, 4 months ago (2017-08-05 02:23:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2999493002/1
3 years, 4 months ago (2017-08-08 21:48:46 UTC) #4
commit-bot: I haz the power
3 years, 4 months ago (2017-08-08 21:56:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/678bb0eefa62cbad33363d38ef4ccc8567c38a4e

Powered by Google App Engine
This is Rietveld 408576698