Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Unified Diff: logdog/client/annotee/annotation/annotation.go

Issue 2999493002: Rename deployment manifests back to source manifests. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: logdog/client/annotee/annotation/annotation.go
diff --git a/logdog/client/annotee/annotation/annotation.go b/logdog/client/annotee/annotation/annotation.go
index 57859f915174a368dfa1d4c082161fcd0a2a54c7..b2339f183725c4974e337b2e3edd1257a706914c 100644
--- a/logdog/client/annotee/annotation/annotation.go
+++ b/logdog/client/annotee/annotation/annotation.go
@@ -379,28 +379,28 @@ func (s *State) Append(annotation string) error {
break
// This is ONLY supported by annotee, not by buildbot.
- // @@@DEPLOYMENT_MANIFEST@<name>@<sha256>@<url>@@@
- case "DEPLOYMENT_MANIFEST":
+ // @@@SOURCE_MANIFEST@<name>@<sha256>@<url>@@@
+ case "SOURCE_MANIFEST":
parts := strings.SplitN(params, "@", 3)
if len(parts) != 3 {
- return fmt.Errorf("DEPLOYMENT_MANIFEST expected 3 params, got %q", params)
+ return fmt.Errorf("SOURCE_MANIFEST expected 3 params, got %q", params)
}
step := s.RootStep()
- if step.DeploymentManifests == nil {
- step.DeploymentManifests = map[string]*milo.Step_ManifestLink{}
+ if step.SourceManifests == nil {
+ step.SourceManifests = map[string]*milo.Step_ManifestLink{}
}
name, hashHex, url := parts[0], parts[1], parts[2]
hash, err := hex.DecodeString(hashHex)
if err != nil {
- return fmt.Errorf("DEPLOYMENT_MANIFEST has bad hash: %s", err)
+ return fmt.Errorf("SOURCE_MANIFEST has bad hash: %s", err)
}
- if _, ok := step.DeploymentManifests[name]; ok {
- return fmt.Errorf("repeated DEPLOYMENT_MANIFEST name %q", name)
+ if _, ok := step.SourceManifests[name]; ok {
+ return fmt.Errorf("repeated SOURCE_MANIFEST name %q", name)
}
- step.DeploymentManifests[name] = &milo.Step_ManifestLink{
+ step.SourceManifests[name] = &milo.Step_ManifestLink{
Sha256: hash,
Url: url,
}
« no previous file with comments | « common/proto/milo/annotations.pb.go ('k') | logdog/client/annotee/annotation/test_data/coverage.annotations.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698