Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2999453002: Implement forEachParameter in closures, deal with not all closures being localFunctions (Closed)

Created:
3 years, 4 months ago by Emily Fortuna
Modified:
3 years, 4 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handful of closure issues. Implement forEachParameter in closures, deal with not all closures being localFunctions, and point to the constructor head instead of body when calling "getConstructorBody" This reverts commit b74f53aa7412c84765848fab13e323fd15d95bf2. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/15fdc7ceb0ae1bf8911ff50d93b8759a573eca32

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -8 lines) Patch
M pkg/compiler/lib/src/js_model/closure.dart View 3 chunks +33 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Emily Fortuna
These fix the issues we were talking about yesterday. It is a reapplication of this ...
3 years, 4 months ago (2017-08-04 18:09:18 UTC) #5
Emily Fortuna
These fix the issues we were talking about yesterday. It is a reapplication of this ...
3 years, 4 months ago (2017-08-04 18:09:20 UTC) #6
sra1
lgtm
3 years, 4 months ago (2017-08-04 18:21:36 UTC) #7
Emily Fortuna
3 years, 4 months ago (2017-08-04 20:31:22 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:40001) manually as
15fdc7ceb0ae1bf8911ff50d93b8759a573eca32 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698