Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: pkg/compiler/lib/src/kernel/element_map_impl.dart

Issue 2999453002: Implement forEachParameter in closures, deal with not all closures being localFunctions (Closed)
Patch Set: . Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_model/closure.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/kernel/element_map_impl.dart
diff --git a/pkg/compiler/lib/src/kernel/element_map_impl.dart b/pkg/compiler/lib/src/kernel/element_map_impl.dart
index 716243f0e06f68011014a0d461233457ee208eab..0ea848812b398acbfc04acced7577e27559a234f 100644
--- a/pkg/compiler/lib/src/kernel/element_map_impl.dart
+++ b/pkg/compiler/lib/src/kernel/element_map_impl.dart
@@ -2026,7 +2026,8 @@ class JsKernelToElementMap extends KernelToElementMapBase
_memberData.add(new ClosureFunctionData(
new ClosureMemberDefinition(callMethod, closureData.definition.location,
MemberKind.closureCall, node.parent),
- getFunctionType(node)));
+ getFunctionType(node),
+ node));
memberMap[cls.callMethod.name] = cls.callMethod;
return cls;
}
@@ -2094,7 +2095,7 @@ class JsKernelToElementMap extends KernelToElementMapBase
(node is ir.Procedure && node.kind == ir.ProcedureKind.Factory)) {
FunctionEntity entity;
if (node.parent is ir.Constructor) {
- entity = getConstructorBody(node);
+ entity = getConstructorBody(node.parent);
} else {
entity = getMember(node);
}
« no previous file with comments | « pkg/compiler/lib/src/js_model/closure.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698