Implement forEachParameter in closures, deal with not all closures being localFunctions

pkg/compiler/lib/src/kernel/element_map_impl.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.kernel.element_map;
 
 import 'package:kernel/ast.dart' as ir;
 
 import '../closure.dart' show BoxLocal;
 import '../common.dart';
@@ skipping 2008 matching lines @@
     FunctionEntity callMethod = cls.callMethod = new JClosureCallMethod(
         _memberData.length,
         cls,
         _getParameterStructure(node),
         _getAsyncMarker(node));
     _memberList.add(cls.callMethod);
 
     _memberData.add(new ClosureFunctionData(
         new ClosureMemberDefinition(callMethod, closureData.definition.location,
             MemberKind.closureCall, node.parent),
-        getFunctionType(node)));
+        getFunctionType(node),
+        node));
     memberMap[cls.callMethod.name] = cls.callMethod;
     return cls;
   }
 
   _constructClosureFields(
       MemberEntity member,
       KernelClosureClass cls,
       Map<String, MemberEntity> memberMap,
       ir.VariableDeclaration variable,
       int fieldNumber,
@@ skipping 47 matching lines @@
       parts.add('closure');
     }
     ir.TreeNode node = treeNode.parent;
     while (node != null) {
       // TODO(johnniwinther): Simplify computed names.
       if (node is ir.Constructor ||
           node.parent is ir.Constructor ||
           (node is ir.Procedure && node.kind == ir.ProcedureKind.Factory)) {
         FunctionEntity entity;
         if (node.parent is ir.Constructor) {
-          entity = getConstructorBody(node);
+          entity = getConstructorBody(node.parent);
         } else {
           entity = getMember(node);
         }
         parts.add(utils.reconstructConstructorName(entity));
       } else {
         if (node is ir.Class) {
           parts.add(Elements.operatorNameToIdentifier(node.name));
         } else if (node is ir.Procedure) {
           parts.add(Elements.operatorNameToIdentifier(node.name.name));
         }
@@ skipping 18 matching lines @@
   ///
   /// These names are not used in generated code, just as element name.
   String _getClosureVariableName(String name, int id) {
     return "_captured_${name}_$id";
   }
 
   String getDeferredUri(ir.LibraryDependency node) {
     throw new UnimplementedError('JsKernelToElementMap.getDeferredUri');
   }
 }