[vm, gardening] Move --trace-service output to stderr.

[vm, gardening] Move --trace-service output to stderr.

Prevents interleaving with output on stdout that is parsed. E.g.,

R=cbernaschina@google.com

FormatException: Invalid character (at character 24)
http://127.0.0.1:59909/[+400ms] Isolate kernel-service.dart.snapshot$main-5...
Committed: https://github.com/dart-lang/sdk/commit/8879e6a2c0f6fe00a931a50ce417f6b5ef24f877

[rmacnak, 2017-08-09 17:55:02]

rmacnak@google.com changed reviewers:
+ cbernaschina@google.com

[rmacnak, 2017-08-09 17:55:18]

Description was changed from

==========
[vm, gardening] Move --trace-service output to stderr.

Preverts interleaving with output on stdout that is parsed. E.g.,

FormatException: Invalid character (at character 24)
http://127.0.0.1:59909/[+400ms] Isolate kernel-service.dart.snapshot$main-5...
==========

to

==========
[vm, gardening] Move --trace-service output to stderr.

Prevents interleaving with output on stdout that is parsed. E.g.,

FormatException: Invalid character (at character 24)
http://127.0.0.1:59909/[+400ms] Isolate kernel-service.dart.snapshot$main-5...
==========

[cbernaschina, 2017-08-09 18:06:16]

On 2017/08/09 17:55:03, rmacnak wrote:

lgtm

with a question:
Can be useful to centralize the Print labels in service.cc?
Something like

#define LOG_LABEL "vm-service: "

...

OS::PrintErr(LOG_LABEL"Booting dart:vmservice library.\n");

[rmacnak, 2017-08-09 20:02:58]

On 2017/08/09 18:06:16, cbernaschina wrote:
> On 2017/08/09 17:55:03, rmacnak wrote:
> 
> lgtm
> 
> with a question:
> Can be useful to centralize the Print labels in service.cc?
> Something like
> 
> #define LOG_LABEL "vm-service: "
> 
> ...
> 
> OS::PrintErr(LOG_LABEL"Booting dart:vmservice library.\n");

I'm not sure about that. It would leave the prints outside of service.cc
different and harder to search for.

[rmacnak, 2017-08-09 20:06:18]

Description was changed from

==========
[vm, gardening] Move --trace-service output to stderr.

Prevents interleaving with output on stdout that is parsed. E.g.,

FormatException: Invalid character (at character 24)
http://127.0.0.1:59909/[+400ms] Isolate kernel-service.dart.snapshot$main-5...
==========

to

==========
[vm, gardening] Move --trace-service output to stderr.

Prevents interleaving with output on stdout that is parsed. E.g.,

R=cbernaschina@google.com

FormatException: Invalid character (at character 24)
http://127.0.0.1:59909/[+400ms] Isolate kernel-service.dart.snapshot$main-5...
Committed:
https://github.com/dart-lang/sdk/commit/8879e6a2c0f6fe00a931a50ce417f6b5ef24f877
==========

[rmacnak, 2017-08-09 20:06:20]

Committed patchset #1 (id:1) manually as
8879e6a2c0f6fe00a931a50ce417f6b5ef24f877 (presubmit successful).