Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: runtime/vm/isolate.cc

Issue 2998713002: [vm, gardening] Move --trace-service output to stderr. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/vmservice.cc ('k') | runtime/vm/json_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index d97a4cfa1548eb9d7058dd4b76b3983f69f2e772..34ebc67aaef6de0ede34196ece079fec68b8e3ab 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -587,8 +587,8 @@ void IsolateMessageHandler::NotifyPauseOnStart() {
ServiceEvent pause_event(I, ServiceEvent::kPauseStart);
Service::HandleEvent(&pause_event);
} else if (FLAG_trace_service) {
- OS::Print("vm-service: Dropping event of type PauseStart (%s)\n",
- I->name());
+ OS::PrintErr("vm-service: Dropping event of type PauseStart (%s)\n",
+ I->name());
}
}
@@ -603,7 +603,8 @@ void IsolateMessageHandler::NotifyPauseOnExit() {
ServiceEvent pause_event(I, ServiceEvent::kPauseExit);
Service::HandleEvent(&pause_event);
} else if (FLAG_trace_service) {
- OS::Print("vm-service: Dropping event of type PauseExit (%s)\n", I->name());
+ OS::PrintErr("vm-service: Dropping event of type PauseExit (%s)\n",
+ I->name());
}
}
#endif // !PRODUCT
@@ -2161,13 +2162,13 @@ RawObject* Isolate::InvokePendingServiceExtensionCalls() {
arguments.SetAt(kPendingEntrySize, Bool::Get(FLAG_trace_service));
if (FLAG_trace_service) {
- OS::Print("[+%" Pd64 "ms] Isolate %s invoking _runExtension for %s\n",
- Dart::UptimeMillis(), name(), method_name.ToCString());
+ OS::PrintErr("[+%" Pd64 "ms] Isolate %s invoking _runExtension for %s\n",
+ Dart::UptimeMillis(), name(), method_name.ToCString());
}
result = DartEntry::InvokeFunction(run_extension, arguments);
if (FLAG_trace_service) {
- OS::Print("[+%" Pd64 "ms] Isolate %s : _runExtension complete for %s\n",
- Dart::UptimeMillis(), name(), method_name.ToCString());
+ OS::PrintErr("[+%" Pd64 "ms] Isolate %s _runExtension complete for %s\n",
+ Dart::UptimeMillis(), name(), method_name.ToCString());
}
// Propagate the error.
if (result.IsError()) {
@@ -2203,8 +2204,9 @@ void Isolate::AppendServiceExtensionCall(const Instance& closure,
const Instance& reply_port,
const Instance& id) {
if (FLAG_trace_service) {
- OS::Print("[+%" Pd64 "ms] Isolate %s ENQUEUING request for extension %s\n",
- Dart::UptimeMillis(), name(), method_name.ToCString());
+ OS::PrintErr("[+%" Pd64
+ "ms] Isolate %s ENQUEUING request for extension %s\n",
+ Dart::UptimeMillis(), name(), method_name.ToCString());
}
GrowableObjectArray& calls =
GrowableObjectArray::Handle(pending_service_extension_calls());
« no previous file with comments | « runtime/lib/vmservice.cc ('k') | runtime/vm/json_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698