[vm, gardening] Move --trace-service output to stderr.

runtime/vm/isolate.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/isolate.h"
 
 #include "include/dart_api.h"
 #include "include/dart_native_api.h"
 #include "platform/assert.h"
 #include "platform/text_buffer.h"
@@ skipping 569 matching lines @@
   if (!FLAG_support_service) {
     return;
   }
   if (Service::debug_stream.enabled() || FLAG_warn_on_pause_with_no_debugger) {
     StartIsolateScope start_isolate(I);
     StackZone zone(T);
     HandleScope handle_scope(T);
     ServiceEvent pause_event(I, ServiceEvent::kPauseStart);
     Service::HandleEvent(&pause_event);
   } else if (FLAG_trace_service) {
-    OS::Print("vm-service: Dropping event of type PauseStart (%s)\n",
-              I->name());
+    OS::PrintErr("vm-service: Dropping event of type PauseStart (%s)\n",
+                 I->name());
   }
 }
 
 void IsolateMessageHandler::NotifyPauseOnExit() {
   if (!FLAG_support_service) {
     return;
   }
   if (Service::debug_stream.enabled() || FLAG_warn_on_pause_with_no_debugger) {
     StartIsolateScope start_isolate(I);
     StackZone zone(T);
     HandleScope handle_scope(T);
     ServiceEvent pause_event(I, ServiceEvent::kPauseExit);
     Service::HandleEvent(&pause_event);
   } else if (FLAG_trace_service) {
-    OS::Print("vm-service: Dropping event of type PauseExit (%s)\n", I->name());
+    OS::PrintErr("vm-service: Dropping event of type PauseExit (%s)\n",
+                 I->name());
   }
 }
 #endif  // !PRODUCT
 
 #if defined(DEBUG)
 void IsolateMessageHandler::CheckAccess() {
   ASSERT(IsCurrentIsolate());
 }
 #endif
 
@@ skipping 1537 matching lines @@
     ASSERT(!parameter_values.IsNull());
     arguments.SetAt(kPendingValuesIndex, parameter_values);
     reply_port ^= calls.At(i + kPendingReplyPortIndex);
     ASSERT(!reply_port.IsNull());
     arguments.SetAt(kPendingReplyPortIndex, reply_port);
     id ^= calls.At(i + kPendingIdIndex);
     arguments.SetAt(kPendingIdIndex, id);
     arguments.SetAt(kPendingEntrySize, Bool::Get(FLAG_trace_service));
 
     if (FLAG_trace_service) {
-      OS::Print("[+%" Pd64 "ms] Isolate %s invoking _runExtension for %s\n",
-                Dart::UptimeMillis(), name(), method_name.ToCString());
+      OS::PrintErr("[+%" Pd64 "ms] Isolate %s invoking _runExtension for %s\n",
+                   Dart::UptimeMillis(), name(), method_name.ToCString());
     }
     result = DartEntry::InvokeFunction(run_extension, arguments);
     if (FLAG_trace_service) {
-      OS::Print("[+%" Pd64 "ms] Isolate %s : _runExtension complete for %s\n",
-                Dart::UptimeMillis(), name(), method_name.ToCString());
+      OS::PrintErr("[+%" Pd64 "ms] Isolate %s _runExtension complete for %s\n",
+                   Dart::UptimeMillis(), name(), method_name.ToCString());
     }
     // Propagate the error.
     if (result.IsError()) {
       // Remaining service extension calls are dropped.
       if (!result.IsUnwindError()) {
         // Send error back over the protocol.
         Service::PostError(method_name, parameter_keys, parameter_values,
                            reply_port, id, Error::Cast(result));
       }
       return result.raw();
@@ skipping 15 matching lines @@
   return r;
 }
 
 void Isolate::AppendServiceExtensionCall(const Instance& closure,
                                          const String& method_name,
                                          const Array& parameter_keys,
                                          const Array& parameter_values,
                                          const Instance& reply_port,
                                          const Instance& id) {
   if (FLAG_trace_service) {
-    OS::Print("[+%" Pd64 "ms] Isolate %s ENQUEUING request for extension %s\n",
-              Dart::UptimeMillis(), name(), method_name.ToCString());
+    OS::PrintErr("[+%" Pd64
+                 "ms] Isolate %s ENQUEUING request for extension %s\n",
+                 Dart::UptimeMillis(), name(), method_name.ToCString());
   }
   GrowableObjectArray& calls =
       GrowableObjectArray::Handle(pending_service_extension_calls());
   if (calls.IsNull()) {
     calls ^= GrowableObjectArray::New();
     ASSERT(!calls.IsNull());
     set_pending_service_extension_calls(calls);
   }
   ASSERT(kPendingHandlerIndex == 0);
   calls.Add(closure);
@@ skipping 624 matching lines @@
 void IsolateSpawnState::DecrementSpawnCount() {
   ASSERT(spawn_count_monitor_ != NULL);
   ASSERT(spawn_count_ != NULL);
   MonitorLocker ml(spawn_count_monitor_);
   ASSERT(*spawn_count_ > 0);
   *spawn_count_ = *spawn_count_ - 1;
   ml.Notify();
 }
 
 }  // namespace dart