[vm] Revert changes related to triggering the 1st GC

[vm] Revert changes related to triggering the 1st GC

This is the partial revert of the
8d6bc876f0eddb3cb248e112f4684616be82542c

That CL caused noticeable slowdown of gen_snapshot on Mac and Windows.
Reverting this part of the CL fixes regression.

Closes https://github.com/dart-lang/sdk/issues/30317

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/69817eea182384b40ef658d578fd49cac00c5874

[alexmarkov, 2017-08-04 19:44:53]

Description was changed from

==========
Revert changes related to triggering the 1st GC

BUG=
==========

to

==========
[vm] Revert changes related to triggering the 1st GC

This is the partial revert of the
8d6bc876f0eddb3cb248e112f4684616be82542c

That CL caused noticeable slowdown of gen_snapshot on Mac and Windows.
Reverting this part of the CL fixes regression.

Closes https://github.com/dart-lang/sdk/issues/30317
==========

[alexmarkov, 2017-08-04 19:45:59]

alexmarkov@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com, zra@google.com

[zra, 2017-08-04 20:08:29]

lgtm w/ nit.

https://codereview.chromium.org/2998473002/diff/1/runtime/vm/isolate.h
File runtime/vm/isolate.h (right):

https://codereview.chromium.org/2998473002/diff/1/runtime/vm/isolate.h#newcod...
runtime/vm/isolate.h:784: int64_t start_time_micros_;
In non-product builds, this will break up the bool fields. Could you move this
instead down to where I've noted below?

https://codereview.chromium.org/2998473002/diff/1/runtime/vm/isolate.h#newcod...
runtime/vm/isolate.h:848: // All other fields go here.
Somewhere below here.

[zra, 2017-08-04 20:08:55]

Also thanks for tracking this down =)

[alexmarkov, 2017-08-04 20:28:06]

https://codereview.chromium.org/2998473002/diff/1/runtime/vm/isolate.h
File runtime/vm/isolate.h (right):

https://codereview.chromium.org/2998473002/diff/1/runtime/vm/isolate.h#newcod...
runtime/vm/isolate.h:784: int64_t start_time_micros_;
On 2017/08/04 20:08:28, zra wrote:
> In non-product builds, this will break up the bool fields. Could you move this
> instead down to where I've noted below?

Done.

https://codereview.chromium.org/2998473002/diff/1/runtime/vm/isolate.h#newcod...
runtime/vm/isolate.h:848: // All other fields go here.
On 2017/08/04 20:08:28, zra wrote:
> Somewhere below here.

Done.

[alexmarkov, 2017-08-04 20:32:04]

Description was changed from

==========
[vm] Revert changes related to triggering the 1st GC

This is the partial revert of the
8d6bc876f0eddb3cb248e112f4684616be82542c

That CL caused noticeable slowdown of gen_snapshot on Mac and Windows.
Reverting this part of the CL fixes regression.

Closes https://github.com/dart-lang/sdk/issues/30317
==========

to

==========
[vm] Revert changes related to triggering the 1st GC

This is the partial revert of the
8d6bc876f0eddb3cb248e112f4684616be82542c

That CL caused noticeable slowdown of gen_snapshot on Mac and Windows.
Reverting this part of the CL fixes regression.

Closes https://github.com/dart-lang/sdk/issues/30317

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/69817eea182384b40ef658d578fd49cac00c5874
==========

[alexmarkov, 2017-08-04 20:32:06]

Committed patchset #2 (id:20001) manually as
69817eea182384b40ef658d578fd49cac00c5874 (presubmit successful).