Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: runtime/vm/pages.cc

Issue 2998473002: [vm] Revert changes related to triggering the 1st GC (Closed)
Patch Set: Address review comments Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/pages.cc
diff --git a/runtime/vm/pages.cc b/runtime/vm/pages.cc
index 895d2b2439878d29e023f9e705cc918890b98eed..978899b5621dd734c222cbad59c447298492f2b6 100644
--- a/runtime/vm/pages.cc
+++ b/runtime/vm/pages.cc
@@ -1149,7 +1149,6 @@ bool PageSpaceController::NeedsGarbageCollection(SpaceUsage after) const {
intptr_t capacity_increase_in_pages =
capacity_increase_in_words / PageSpace::kPageSizeInWords;
double multiplier = 1.0;
-#if !defined(PRODUCT)
// To avoid waste, the first GC should be triggered before too long. After
// kInitialTimeoutSeconds, gradually lower the capacity limit.
static const double kInitialTimeoutSeconds = 1.00;
@@ -1160,7 +1159,6 @@ bool PageSpaceController::NeedsGarbageCollection(SpaceUsage after) const {
multiplier *= seconds_since_init / kInitialTimeoutSeconds;
}
}
-#endif // !defined(PRODUCT)
bool needs_gc = capacity_increase_in_pages * multiplier > grow_heap_;
if (FLAG_log_growth) {
OS::PrintErr("%s: %" Pd " * %f %s %" Pd "\n",
« no previous file with comments | « runtime/vm/isolate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698