[vm] Revert changes related to triggering the 1st GC

runtime/vm/isolate.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef RUNTIME_VM_ISOLATE_H_
 #define RUNTIME_VM_ISOLATE_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/atomic.h"
@@ skipping 209 matching lines @@
   // is unscheduled by the isolate (or never scheduled).
   bool IsMutatorThreadScheduled() {
     return mutator_thread_ != NULL && mutator_thread_->heap() != NULL;
   }
 
   const char* name() const { return name_; }
 
 #if !defined(PRODUCT)
   const char* debugger_name() const { return debugger_name_; }
   void set_debugger_name(const char* name);
+#endif  // !defined(PRODUCT)
+
   int64_t UptimeMicros() const;
-#endif  // !defined(PRODUCT)
 
   Dart_Port main_port() const { return main_port_; }
   void set_main_port(Dart_Port port) {
     ASSERT(main_port_ == 0);  // Only set main port once.
     main_port_ = port;
   }
   Dart_Port origin_id() const { return origin_id_; }
   void set_origin_id(Dart_Port id) {
     ASSERT((id == main_port_ && origin_id_ == 0) || (origin_id_ == main_port_));
     origin_id_ = id;
@@ skipping 531 matching lines @@
   ClassTable class_table_;
   bool single_step_;
 
   // Try to keep boolean fields together.
   bool errors_fatal_;
   bool is_runnable_;
   bool is_service_isolate_;
   bool compilation_allowed_;
   bool all_classes_finalized_;
   bool remapping_cids_;
+  int64_t start_time_micros_;

[zra, 2017/08/04 20:08:28]

In non-product builds, this will break up the bool fields. Could you move this
instead down to where I've noted below?

[alexmarkov, 2017/08/04 20:28:06]

Done.

 
 // Fields that aren't needed in a product build go here with boolean flags at
 // the top.
 #if !defined(PRODUCT)
   bool resume_request_;
   bool has_attempted_reload_;  // Has a reload ever been attempted?
   // Should we pause in the debug message loop after this request?
   bool should_pause_post_service_request_;
 
   char* debugger_name_;
-  int64_t start_time_micros_;
   Debugger* debugger_;
   int64_t last_resume_timestamp_;
 
 // Isolate-specific flags.
 #define DECLARE_FIELD(name, isolate_flag_name, flag_name) bool name##_;
   ISOLATE_FLAG_LIST(DECLARE_FIELD)
 #undef DECLARE_FIELD
 
   // Timestamps of last operation via service.
   int64_t last_allocationprofile_accumulator_reset_timestamp_;
@@ skipping 33 matching lines @@
 
   intptr_t no_reload_scope_depth_;  // we can only reload when this is 0.
   // Per-isolate copy of FLAG_reload_every.
   intptr_t reload_every_n_stack_overflow_checks_;
   IsolateReloadContext* reload_context_;
   int64_t last_reload_timestamp_;
   // Ring buffer of objects assigned an id.
   ObjectIdRing* object_id_ring_;
 #endif  // !defined(PRODUCT)
 
   // All other fields go here.

[zra, 2017/08/04 20:08:28]

Somewhere below here.

[alexmarkov, 2017/08/04 20:28:06]

Done.

   ThreadRegistry* thread_registry_;
   SafepointHandler* safepoint_handler_;
   Dart_MessageNotifyCallback message_notify_callback_;
   char* name_;
   Dart_Port main_port_;
   Dart_Port origin_id_;  // Isolates created by spawnFunc have some origin id.
   uint64_t pause_capability_;
   uint64_t terminate_capability_;
   void* init_callback_data_;
   Dart_EnvironmentCallback environment_callback_;
@@ skipping 202 matching lines @@
   intptr_t* spawn_count_;
 
   Dart_IsolateFlags isolate_flags_;
   bool paused_;
   bool errors_are_fatal_;
 };
 
 }  // namespace dart
 
 #endif  // RUNTIME_VM_ISOLATE_H_