Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 2996633002: scheduler: fix import. (Closed)

Created:
3 years, 4 months ago by tandrii(chromium)
Modified:
3 years, 4 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M scheduler/appengine/acl/acl.go View 2 chunks +1 line, -1 line 2 comments Download

Messages

Total messages: 10 (3 generated)
tandrii(chromium)
3 years, 4 months ago (2017-08-08 12:34:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2996633002/1
3 years, 4 months ago (2017-08-08 12:35:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://github.com/luci/luci-go/commit/1870e44fd36cb9dbb2fc4e7ae0e09b5938ff4a9c
3 years, 4 months ago (2017-08-08 12:40:37 UTC) #6
Vadim Sh.
lgtm https://codereview.chromium.org/2996633002/diff/1/scheduler/appengine/acl/acl.go File scheduler/appengine/acl/acl.go (right): https://codereview.chromium.org/2996633002/diff/1/scheduler/appengine/acl/acl.go#newcode29 scheduler/appengine/acl/acl.go:29: "golang.org/x/net/context" nit: we usually put non-luci imports before ...
3 years, 4 months ago (2017-08-08 18:12:06 UTC) #7
tandrii(chromium)
https://codereview.chromium.org/2996633002/diff/1/scheduler/appengine/acl/acl.go File scheduler/appengine/acl/acl.go (right): https://codereview.chromium.org/2996633002/diff/1/scheduler/appengine/acl/acl.go#newcode29 scheduler/appengine/acl/acl.go:29: "golang.org/x/net/context" On 2017/08/08 18:12:06, Vadim Sh. wrote: > nit: ...
3 years, 4 months ago (2017-08-08 18:47:27 UTC) #8
tandrii(chromium)
3 years, 4 months ago (2017-08-08 18:47:29 UTC) #9
tandrii(chromium)
3 years, 4 months ago (2017-08-08 18:47:30 UTC) #10
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698