Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2996623002: Include zone in GCE instance base name (Closed)

Created:
3 years, 4 months ago by smut
Modified:
3 years, 4 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Include zone in GCE instance base name To prevent ending up with a same-named instance in two different zones, since Machine Provider expects to key on the combination of backend:hostname. Bug: 753079 Review-Url: https://codereview.chromium.org/2996623002 Committed: https://github.com/luci/luci-py/commit/623d6fc93ee051a7b7cd9b92670f89280da7ad6e

Patch Set 1 #

Total comments: 1

Patch Set 2 : Unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2 lines) Patch
M appengine/gce-backend/instance_group_managers.py View 1 chunk +6 lines, -2 lines 0 comments Download
M appengine/gce-backend/instance_group_managers_test.py View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
smut
The instance group manager's name remains the same, but this will ensure the instances created ...
3 years, 4 months ago (2017-08-07 21:56:34 UTC) #2
Vadim Sh.
1. I'm worried by a lack of any unit test changes. 2. What will happen ...
3 years, 4 months ago (2017-08-07 22:49:02 UTC) #3
smut
On 2017/08/07 22:49:02, Vadim Sh. wrote: > 1. I'm worried by a lack of any ...
3 years, 4 months ago (2017-08-07 23:43:45 UTC) #5
Vadim Sh.
> > 2. What will happen when we deploy this change? Will it gracefully drain ...
3 years, 4 months ago (2017-08-07 23:46:51 UTC) #6
smut
On 2017/08/07 23:46:51, Vadim Sh. wrote: > > > 2. What will happen when we ...
3 years, 4 months ago (2017-08-07 23:49:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2996623002/40001
3 years, 4 months ago (2017-08-07 23:50:25 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://github.com/luci/luci-py/commit/623d6fc93ee051a7b7cd9b92670f89280da7ad6e
3 years, 4 months ago (2017-08-07 23:52:43 UTC) #12
Vadim Sh.
3 years, 4 months ago (2017-08-07 23:54:17 UTC) #13
Message was sent while issue was closed.
On 2017/08/07 23:49:47, smut wrote:
> On 2017/08/07 23:46:51, Vadim Sh. wrote:
> > > > 2. What will happen when we deploy this change? Will it gracefully drain
> old
> > > IGM
> > > > and populate new IGM?
> > > 
> > > No. Only config changes do that. We will need to make a change in
> > templates.cfg,
> > > which is impending anyway because I need to move these to us-west.
> > 
> > But what will happen when we deploy this change? Will everything continue to
> > work as before until we make a config change? I'm worried it may go "crazy"
> and
> > create new IGM group with new name (that includes the zone), "forgetting"
> about
> > old one (or something like that).
> > 
> > lgtm assuming you'll verify on -dev that nothing bad is happening
> 
> Nothing will happen. I didn't make any change to the IGM name. This changes
the
> "create-new-IGM" RPC. Until we make a config change, GCE Backend will see that
> it doesn't need to make a new IGM because IGMs matching the config already
> exist. On config change, it will behave as normal except sending a slightly
> different parameter to GCE in the "create-new-IGM" RPC.

Thanks for explanation :) Makes sense now.

Powered by Google App Engine
This is Rietveld 408576698