Include zone in GCE instance base name

appengine/gce-backend/instance_group_managers_test.py

 #!/usr/bin/python
 # Copyright 2016 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 """Unit tests for instance_group_managers.py."""
 
 import unittest
 
 import test_env
@@ skipping 431 matching lines @@
     expected_keys = [
         key,
     ]
 
     self.assertItemsEqual(
         instance_group_managers.get_drained_instance_group_managers(),
         expected_keys,
     )
 
 
+class GetBaseNameTest(test_case.TestCase):
+  """Tests for instance_group_managers.get_base_name."""
+
+  def test_get_base_name(self):
+    """Ensures base instance name is generated correctly."""
+    key = models.InstanceGroupManager(
+        key=instance_group_managers.get_instance_group_manager_key(
+            'base-name',
+            'revision-extra-long',
+            'zone',
+        ),
+        minimum_size=10,
+        maximum_size=10,
+        url='https://example.com',
+    ).put()
+    models.InstanceTemplateRevision(
+        key=key.parent(),
+    ).put()
+    models.InstanceTemplate(key=key.parent().parent()).put()
+
+    self.assertEqual(
+        instance_group_managers.get_base_name(key.get()),
+        'base-name-revision-zone',
+    )
+
+
 class GetInstanceGroupManagerToDeleteTest(test_case.TestCase):
   """Tests for instance_group_managers.get_instance_group_manager_to_delete."""
 
   def test_entity_doesnt_exist(self):
     """Ensures no URL when the entity doesn't exist."""
     key = ndb.Key(models.InstanceGroupManager, 'fake-key')
     self.failIf(
         instance_group_managers.get_instance_group_manager_to_delete(key))
 
   def test_instances(self):
@@ skipping 659 matching lines @@
         ),
     ).put()
 
     instance_group_managers.update_url(key, 'url')
 
     self.assertEqual(key.get().url, 'url')
 
 
 if __name__ == '__main__':
   unittest.main()