Issue 2996543002: add error message as a comment on the logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2996543002: add error message as a comment on the logs (Closed)

Created:
3 years, 4 months ago by Siggi Cherem (dart-lang)

Modified:
3 years, 4 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -10 lines)			Patch
M	pkg/compiler/tool/status_files/log_parser.dart	View	2 chunks	+7 lines, -3 lines	0 comments	Download
M	pkg/compiler/tool/status_files/record.dart	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	pkg/compiler/tool/status_files/update_from_log.dart	View	4 chunks	+13 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

Siggi Cherem (dart-lang)

I'll revert the dart2js_native.status from this CL, just wanted to include it as an example ...

3 years, 4 months ago (2017-08-04 19:54:15 UTC) #2

Siggi Cherem (dart-lang)

Committed patchset #2 (id:20001) manually as 06a929434e07451dc40bc1ae12b1280ce9de2dca (presubmit successful).

3 years, 4 months ago (2017-08-04 20:21:45 UTC) #4

Message was sent while issue was closed.

lgtm