Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: pkg/compiler/tool/status_files/log_parser.dart

Issue 2996543002: add error message as a comment on the logs (Closed)
Patch Set: only update script Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/tool/status_files/record.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/tool/status_files/log_parser.dart
diff --git a/pkg/compiler/tool/status_files/log_parser.dart b/pkg/compiler/tool/status_files/log_parser.dart
index 964fba380b803a970a4813cee89ef2af993fe5f8..33d50f4197bec0b9ddfc17b57f09b9cf226926fd 100644
--- a/pkg/compiler/tool/status_files/log_parser.dart
+++ b/pkg/compiler/tool/status_files/log_parser.dart
@@ -14,6 +14,7 @@ List<Record> parse(String log) {
var config;
var expected;
var actual;
+ var reason;
bool reproIsNext = false;
for (var line in log.split('\n')) {
if (line.startsWith("FAILED: ")) {
@@ -36,10 +37,13 @@ List<Record> parse(String log) {
if (line.startsWith("Actual: ")) {
actual = line.substring("Actual: ".length).trim();
}
+ if (line.startsWith("The compiler crashed:")) {
+ reason = line.substring("The compiler crashed:".length).trim();
+ }
if (reproIsNext) {
- records
- .add(new Record(suite, test, config, expected, actual, line.trim()));
- suite = test = config = expected = actual = null;
+ records.add(new Record(
+ suite, test, config, expected, actual, reason, line.trim()));
+ suite = test = config = expected = actual = reason = null;
reproIsNext = false;
}
if (line.startsWith("Short reproduction command (experimental):")) {
« no previous file with comments | « no previous file | pkg/compiler/tool/status_files/record.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698