Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: pkg/compiler/tool/status_files/record.dart

Issue 2996543002: add error message as a comment on the logs (Closed)
Patch Set: only update script Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/tool/status_files/log_parser.dart ('k') | pkg/compiler/tool/status_files/update_from_log.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/tool/status_files/record.dart
diff --git a/pkg/compiler/tool/status_files/record.dart b/pkg/compiler/tool/status_files/record.dart
index 1162978a8befc711106573db351ccb575d27cdf1..c829bae89d4805ee0f64bcbb6a9e67f532f16ab2 100644
--- a/pkg/compiler/tool/status_files/record.dart
+++ b/pkg/compiler/tool/status_files/record.dart
@@ -14,6 +14,7 @@ class Record implements Comparable<Record> {
final String expected;
final String actual;
final String repro;
+ final String reason;
// TODO(sigmund): extract also a failure reason if any (e.g. a stack trace or
// error message for crashes).
@@ -21,7 +22,7 @@ class Record implements Comparable<Record> {
bool get isPassing => actual == 'Pass';
Record(this.suite, this.test, this.config, this.expected, this.actual,
- this.repro);
+ this.reason, this.repro);
int compareTo(Record other) {
if (suite == null && other.suite != null) return -1;
« no previous file with comments | « pkg/compiler/tool/status_files/log_parser.dart ('k') | pkg/compiler/tool/status_files/update_from_log.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698