Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 2995543003: [recipe_engine] Set presentation.status before OutputPlaceholder.result. (Closed)

Created:
3 years, 4 months ago by iannucci
Modified:
3 years, 4 months ago
Reviewers:
dnj, stgao
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[recipe_engine] Set presentation.status before OutputPlaceholder.result. This allows OutputPlaceholder.result to switch behavior based on the result's status (i.e. add debugging information when the step fails, but be silent otherwise). R=dnj@chromium.org, stgao@chromium.org BUG= Review-Url: https://codereview.chromium.org/2995543003 Committed: https://github.com/luci/recipes-py/commit/e183af00ebfb42ec3790682ff35942b86de77914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M recipe_engine/run.py View 1 chunk +3 lines, -9 lines 0 comments Download
M recipe_engine/types.py View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
iannucci
3 years, 4 months ago (2017-08-04 18:36:50 UTC) #1
stgao
lgtm
3 years, 4 months ago (2017-08-04 18:40:17 UTC) #2
dnj
lgtm
3 years, 4 months ago (2017-08-04 18:40:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2995543003/1
3 years, 4 months ago (2017-08-04 18:40:56 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2017-08-04 18:47:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/e183af00ebfb42ec3790682ff35942b86de...

Powered by Google App Engine
This is Rietveld 408576698