Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: recipe_engine/types.py

Issue 2995543003: [recipe_engine] Set presentation.status before OutputPlaceholder.result. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « recipe_engine/run.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_engine/types.py
diff --git a/recipe_engine/types.py b/recipe_engine/types.py
index d14244cfb3b63c0b89686d400c9a039763478b00..1a81bd7900bd124d77d954069504163172fe2495 100644
--- a/recipe_engine/types.py
+++ b/recipe_engine/types.py
@@ -174,6 +174,14 @@ class StepData(object):
self._retcode = retcode
self._presentation = StepPresentation()
+ if retcode in step_config.ok_ret:
+ self._presentation.status = 'SUCCESS'
+ else:
+ if not step_config.infra_step:
+ self._presentation.status = 'FAILURE'
+ else:
+ self._presentation.status = 'EXCEPTION'
+
self.abort_reason = None
@property
« no previous file with comments | « recipe_engine/run.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698