Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2994333002: Various redemptions (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 4 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Fix + status updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -172 lines) Patch
M pkg/compiler/lib/src/common_elements.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/collector.dart View 3 chunks +13 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart View 5 chunks +10 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 11 chunks +46 lines, -43 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/registry.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/type_test_registry.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_model/closure.dart View 1 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 1 2 chunks +11 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/env.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/universe/codegen_world_builder.dart View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 2 4 chunks +0 lines, -6 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 2 34 chunks +9 lines, -94 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Johnni Winther
3 years, 4 months ago (2017-08-16 12:58:57 UTC) #2
Emily Fortuna
lgtm
3 years, 4 months ago (2017-08-16 16:11:39 UTC) #3
Johnni Winther
Committed patchset #1 (id:1) manually as 49b064da419f6eb141c980aec15296a4bb517956 (presubmit successful).
3 years, 4 months ago (2017-08-17 07:46:28 UTC) #5
Johnni Winther
3 years, 4 months ago (2017-08-17 13:54:46 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
7c77f2db487ae9f69cd98b29e43d81f2c86b8e09 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698