Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(901)

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/collector.dart

Issue 2994333002: Various redemptions (Closed)
Patch Set: Fix + status updates Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart b/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
index ee71c76bc0a502b258e8ffd6ba92922c9a7a123f..245d50be5fb429f5226cc882d9fdd4b8a00af372 100644
--- a/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
+++ b/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
@@ -48,7 +48,7 @@ class Collector {
/// This flag is updated in [computeNeededConstants].
bool outputContainsConstantList = false;
- final List<ClassElement> nativeClassesAndSubclasses = <ClassElement>[];
+ final List<ClassEntity> nativeClassesAndSubclasses = <ClassEntity>[];
List<TypedefEntity> typedefsNeededForReflection;
@@ -88,7 +88,7 @@ class Collector {
*/
Function computeClassFilter() {
if (_mirrorsData.isTreeShakingDisabled) {
- return (ClassElement cls) => true;
+ return (ClassEntity cls) => true;
}
Set<ClassEntity> unneededClasses = new Set<ClassEntity>();
@@ -136,17 +136,24 @@ class Collector {
if (_mirrorsData.mustRetainMetadata) {
// TODO(floitsch): verify that we don't run through the same elements
// multiple times.
- for (MemberElement element in _generatedCode.keys) {
+ for (MemberEntity element in _generatedCode.keys) {
if (_mirrorsData.isMemberAccessibleByReflection(element)) {
_mirrorsData.retainMetadataOfMember(element);
}
}
- for (ClassElement cls in neededClasses) {
+ for (ClassEntity cls in neededClasses) {
final onlyForRti = classesOnlyNeededForRti.contains(cls);
if (!onlyForRti) {
_mirrorsData.retainMetadataOfClass(cls);
- new FieldVisitor(_options, _elementEnvironment, _worldBuilder,
- _nativeData, _mirrorsData, _namer, _closedWorld)
+ new FieldVisitor(
+ _options,
+ _elementEnvironment,
+ _commonElements,
+ _worldBuilder,
+ _nativeData,
+ _mirrorsData,
+ _namer,
+ _closedWorld)
.visitFields((FieldEntity member,
js.Name name,
js.Name accessorName,
« no previous file with comments | « pkg/compiler/lib/src/common_elements.dart ('k') | pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698