chrome/browser/ui/views/omnibox/omnibox_view_views.h - Issue 29943002: Limit display of the virtual keyboard to state changes triggered from a user gesture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.h

Issue 29943002: Limit display of the virtual keyboard to state changes triggered from a user gesture. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address reviewer feedback. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/search/search_tab_helper.cc ('k') | chrome/browser/ui/views/omnibox/omnibox_view_views.cc » ('j') | content/browser/renderer_host/render_widget_host_view_aura.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.h

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.h b/chrome/browser/ui/views/omnibox/omnibox_view_views.h

index 70ee35ca7338f7c43095b84fa93792d15b572213..22cd89f7b0ea1cfa6d7b3fdd5156d9d70ba172b1 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.h

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.h

@@ -110,6 +110,7 @@ class OmniboxViewViews

virtual int GetWidth() const OVERRIDE;

virtual bool IsImeComposing() const OVERRIDE;

virtual bool IsImeShowingPopup() const OVERRIDE;

+ virtual void ShowImeIfNeeded() const OVERRIDE;

sadrul 2014/01/10 19:53:21 Can this just be a private method in OmniboxViewVi

kevers 2014/01/13 16:59:10 Removed const. Requires being part of the Omnibox

// views::TextfieldController:

virtual void ContentsChanged(views::Textfield* sender,