chrome/browser/ui/search/search_tab_helper.cc - Issue 29943002: Limit display of the virtual keyboard to state changes triggered from a user gesture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/search_tab_helper.cc

Issue 29943002: Limit display of the virtual keyboard to state changes triggered from a user gesture. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address reviewer feedback. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_view.cc ('k') | chrome/browser/ui/views/omnibox/omnibox_view_views.h » ('j') | chrome/browser/ui/views/omnibox/omnibox_view_views.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/search/search_tab_helper.cc

diff --git a/chrome/browser/ui/search/search_tab_helper.cc b/chrome/browser/ui/search/search_tab_helper.cc

index 68b6cef11b0871faff731eaaef04722352a877fb..53b9d9ad36b4d71d4bc31ba5b9ee3e6fbbeac6b3 100644

--- a/chrome/browser/ui/search/search_tab_helper.cc

+++ b/chrome/browser/ui/search/search_tab_helper.cc

@@ -447,6 +447,7 @@ void SearchTabHelper::FocusOmnibox(OmniboxFocusState state) {

// visual cue to users who really understand selection state about what

// will happen if they start typing.

omnibox->SelectAll(false);

+ omnibox->ShowImeIfNeeded();

break;

case OMNIBOX_FOCUS_NONE:

// Remove focus only if the popup is closed. This will prevent someone