Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.h

Issue 29943002: Limit display of the virtual keyboard to state changes triggered from a user gesture. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address reviewer feedback. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
6 #define CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_ 6 #define CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 virtual void OnBeforePossibleChange() OVERRIDE; 103 virtual void OnBeforePossibleChange() OVERRIDE;
104 virtual bool OnAfterPossibleChange() OVERRIDE; 104 virtual bool OnAfterPossibleChange() OVERRIDE;
105 virtual gfx::NativeView GetNativeView() const OVERRIDE; 105 virtual gfx::NativeView GetNativeView() const OVERRIDE;
106 virtual gfx::NativeView GetRelativeWindowForPopup() const OVERRIDE; 106 virtual gfx::NativeView GetRelativeWindowForPopup() const OVERRIDE;
107 virtual void SetGrayTextAutocompletion(const base::string16& input) OVERRIDE; 107 virtual void SetGrayTextAutocompletion(const base::string16& input) OVERRIDE;
108 virtual base::string16 GetGrayTextAutocompletion() const OVERRIDE; 108 virtual base::string16 GetGrayTextAutocompletion() const OVERRIDE;
109 virtual int GetTextWidth() const OVERRIDE; 109 virtual int GetTextWidth() const OVERRIDE;
110 virtual int GetWidth() const OVERRIDE; 110 virtual int GetWidth() const OVERRIDE;
111 virtual bool IsImeComposing() const OVERRIDE; 111 virtual bool IsImeComposing() const OVERRIDE;
112 virtual bool IsImeShowingPopup() const OVERRIDE; 112 virtual bool IsImeShowingPopup() const OVERRIDE;
113 virtual void ShowImeIfNeeded() const OVERRIDE;
sadrul 2014/01/10 19:53:21 Can this just be a private method in OmniboxViewVi
kevers 2014/01/13 16:59:10 Removed const. Requires being part of the Omnibox
113 114
114 // views::TextfieldController: 115 // views::TextfieldController:
115 virtual void ContentsChanged(views::Textfield* sender, 116 virtual void ContentsChanged(views::Textfield* sender,
116 const base::string16& new_contents) OVERRIDE; 117 const base::string16& new_contents) OVERRIDE;
117 virtual bool HandleKeyEvent(views::Textfield* sender, 118 virtual bool HandleKeyEvent(views::Textfield* sender,
118 const ui::KeyEvent& key_event) OVERRIDE; 119 const ui::KeyEvent& key_event) OVERRIDE;
119 virtual void OnBeforeUserAction(views::Textfield* sender) OVERRIDE; 120 virtual void OnBeforeUserAction(views::Textfield* sender) OVERRIDE;
120 virtual void OnAfterUserAction(views::Textfield* sender) OVERRIDE; 121 virtual void OnAfterUserAction(views::Textfield* sender) OVERRIDE;
121 virtual void OnAfterCutOrCopy() OVERRIDE; 122 virtual void OnAfterCutOrCopy() OVERRIDE;
122 virtual void OnWriteDragData(ui::OSExchangeData* data) OVERRIDE; 123 virtual void OnWriteDragData(ui::OSExchangeData* data) OVERRIDE;
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 203
203 // Indicates if we want to select all text in the omnibox when we get a 204 // Indicates if we want to select all text in the omnibox when we get a
204 // GESTURE_TAP. We want to select all only when the textfield is not in focus 205 // GESTURE_TAP. We want to select all only when the textfield is not in focus
205 // and gets a tap. So we use this variable to remember focus state before tap. 206 // and gets a tap. So we use this variable to remember focus state before tap.
206 bool select_all_on_gesture_tap_; 207 bool select_all_on_gesture_tap_;
207 208
208 DISALLOW_COPY_AND_ASSIGN(OmniboxViewViews); 209 DISALLOW_COPY_AND_ASSIGN(OmniboxViewViews);
209 }; 210 };
210 211
211 #endif // CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_ 212 #endif // CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698