Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 299393010: Revert 272998 "Revert 241291 "Fix a long standing leak on cancel..." (Closed)

Created:
6 years, 7 months ago by mmenke
Modified:
6 years, 7 months ago
Reviewers:
mmenke
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 272998 "Revert 241291 "Fix a long standing leak on cancel..." > Revert 241291 "Fix a long standing leak on cancellation of rende..." > > This caused crashes elsewhere in the loading code. > > BUG=27911 > > > Fix a long standing leak on cancellation of renderer- > > initiated URLRequests. ResourceDispatcher was not calling > > peer->OnCompletedRequest on cancellation of async requests, > > despite it being expected by WebURLLoaderImpl::Context > > (The only ResourceLoaderBridge::Peer). > > > > This shouldn't impact externally visible behavior at all, > > other than fixing the leak, because once > > WebURLLoaderImpl::Context::Cancel() is called, it will never > > call back into WebURLLoaderImpl. > > > > BUG=328092 > > > > Review URL: https://codereview.chromium.org/113893007 > > TBR=mmenke@chromium.org > > Review URL: https://codereview.chromium.org/306483009 TBR=mmenke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273000

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M trunk/src/content/child/resource_dispatcher.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mmenke
6 years, 7 months ago (2014-05-27 18:18:26 UTC) #1
mmenke
6 years, 7 months ago (2014-05-27 18:19:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r273000 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698