Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 113893007: Fix a long standing leak on cancellation of renderer-initiated URLRequests. (Closed)

Created:
7 years ago by mmenke
Modified:
7 years ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix a long standing leak on cancellation of renderer- initiated URLRequests. ResourceDispatcher was not calling peer->OnCompletedRequest on cancellation of async requests, despite it being expected by WebURLLoaderImpl::Context (The only ResourceLoaderBridge::Peer). This shouldn't impact externally visible behavior at all, other than fixing the leak, because once WebURLLoaderImpl::Context::Cancel() is called, it will never call back into WebURLLoaderImpl. BUG=328092 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241291

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M content/child/resource_dispatcher.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mmenke
jam: Are you a good reviewer for this? Another option would just be to have ...
7 years ago (2013-12-16 22:52:08 UTC) #1
jam
lgtm
7 years ago (2013-12-17 00:19:48 UTC) #2
mmenke
On 2013/12/17 00:19:48, jam wrote: > lgtm Thanks!
7 years ago (2013-12-17 00:32:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/113893007/20001
7 years ago (2013-12-17 00:35:19 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=236999
7 years ago (2013-12-17 05:55:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/113893007/20001
7 years ago (2013-12-17 13:06:02 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-17 15:13:38 UTC) #7
Message was sent while issue was closed.
Change committed as 241291

Powered by Google App Engine
This is Rietveld 408576698