Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 306483009: Revert 241291 "Fix a long standing leak on cancellation of rende..." (Closed)

Created:
6 years, 7 months ago by mmenke
Modified:
6 years, 7 months ago
Reviewers:
mmenke
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 241291 "Fix a long standing leak on cancellation of rende..." This caused crashes elsewhere in the loading code. BUG=27911 > Fix a long standing leak on cancellation of renderer- > initiated URLRequests. ResourceDispatcher was not calling > peer->OnCompletedRequest on cancellation of async requests, > despite it being expected by WebURLLoaderImpl::Context > (The only ResourceLoaderBridge::Peer). > > This shouldn't impact externally visible behavior at all, > other than fixing the leak, because once > WebURLLoaderImpl::Context::Cancel() is called, it will never > call back into WebURLLoaderImpl. > > BUG=328092 > > Review URL: https://codereview.chromium.org/113893007 TBR=mmenke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272998

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M trunk/src/content/child/resource_dispatcher.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mmenke
6 years, 7 months ago (2014-05-27 18:11:15 UTC) #1
mmenke
6 years, 7 months ago (2014-05-27 18:11:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r272998.

Powered by Google App Engine
This is Rietveld 408576698