Issue 299373005: Avoid HeapObject check in HStoreNamedField.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 299373005: Avoid HeapObject check in HStoreNamedField. (Closed)

Created:
6 years, 7 months ago by Benedikt Meurer

Modified:
6 years, 7 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Avoid HeapObject check in HStoreNamedField. This way an HStoreNamedField instruction can never deoptimize itself, which is another important step towards a working store elimination. R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21509

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -121 lines)			Patch
M	src/arm/lithium-arm.cc	View		1 chunk	+1 line, -7 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1	3 chunks	+7 lines, -18 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/arm64/lithium-arm64.cc	View		1 chunk	+1 line, -7 lines	0 comments	Download
M	src/arm64/lithium-codegen-arm64.cc	View	1 2	3 chunks	+9 lines, -15 lines	0 comments	Download
M	src/arm64/macro-assembler-arm64.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View		1 chunk	+4 lines, -7 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		2 chunks	+6 lines, -24 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		1 chunk	+1 line, -10 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		2 chunks	+6 lines, -23 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View		1 chunk	+1 line, -9 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Benedikt Meurer

6 years, 7 months ago (2014-05-27 07:17:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r21509 (presubmit successful).