Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: src/arm/macro-assembler-arm.cc

Issue 299373005: Avoid HeapObject check in HStoreNamedField. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix condition on arm64. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/arm64/lithium-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <limits.h> // For LONG_MIN, LONG_MAX. 5 #include <limits.h> // For LONG_MIN, LONG_MAX.
6 6
7 #include "v8.h" 7 #include "v8.h"
8 8
9 #if V8_TARGET_ARCH_ARM 9 #if V8_TARGET_ARCH_ARM
10 10
(...skipping 383 matching lines...) Expand 10 before | Expand all | Expand 10 after
394 394
395 void MacroAssembler::Store(Register src, 395 void MacroAssembler::Store(Register src,
396 const MemOperand& dst, 396 const MemOperand& dst,
397 Representation r) { 397 Representation r) {
398 ASSERT(!r.IsDouble()); 398 ASSERT(!r.IsDouble());
399 if (r.IsInteger8() || r.IsUInteger8()) { 399 if (r.IsInteger8() || r.IsUInteger8()) {
400 strb(src, dst); 400 strb(src, dst);
401 } else if (r.IsInteger16() || r.IsUInteger16()) { 401 } else if (r.IsInteger16() || r.IsUInteger16()) {
402 strh(src, dst); 402 strh(src, dst);
403 } else { 403 } else {
404 if (r.IsHeapObject()) {
405 AssertNotSmi(src);
406 } else if (r.IsSmi()) {
407 AssertSmi(src);
408 }
404 str(src, dst); 409 str(src, dst);
405 } 410 }
406 } 411 }
407 412
408 413
409 void MacroAssembler::LoadRoot(Register destination, 414 void MacroAssembler::LoadRoot(Register destination,
410 Heap::RootListIndex index, 415 Heap::RootListIndex index,
411 Condition cond) { 416 Condition cond) {
412 if (CpuFeatures::IsSupported(MOVW_MOVT_IMMEDIATE_LOADS) && 417 if (CpuFeatures::IsSupported(MOVW_MOVT_IMMEDIATE_LOADS) &&
413 isolate()->heap()->RootCanBeTreatedAsConstant(index) && 418 isolate()->heap()->RootCanBeTreatedAsConstant(index) &&
(...skipping 3624 matching lines...) Expand 10 before | Expand all | Expand 10 after
4038 sub(result, result, Operand(dividend)); 4043 sub(result, result, Operand(dividend));
4039 } 4044 }
4040 if (ms.shift() > 0) mov(result, Operand(result, ASR, ms.shift())); 4045 if (ms.shift() > 0) mov(result, Operand(result, ASR, ms.shift()));
4041 add(result, result, Operand(dividend, LSR, 31)); 4046 add(result, result, Operand(dividend, LSR, 31));
4042 } 4047 }
4043 4048
4044 4049
4045 } } // namespace v8::internal 4050 } } // namespace v8::internal
4046 4051
4047 #endif // V8_TARGET_ARCH_ARM 4052 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/arm64/lithium-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698