Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 299373005: Avoid HeapObject check in HStoreNamedField. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix condition on arm64. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "v8.h" 5 #include "v8.h"
6 6
7 #include "lithium-allocator-inl.h" 7 #include "lithium-allocator-inl.h"
8 #include "arm/lithium-arm.h" 8 #include "arm/lithium-arm.h"
9 #include "arm/lithium-codegen-arm.h" 9 #include "arm/lithium-codegen-arm.h"
10 #include "hydrogen-osr.h" 10 #include "hydrogen-osr.h"
(...skipping 2298 matching lines...) Expand 10 before | Expand all | Expand 10 after
2309 val = UseTempRegister(instr->value()); 2309 val = UseTempRegister(instr->value());
2310 } else if (instr->field_representation().IsDouble()) { 2310 } else if (instr->field_representation().IsDouble()) {
2311 val = UseRegisterAtStart(instr->value()); 2311 val = UseRegisterAtStart(instr->value());
2312 } else { 2312 } else {
2313 val = UseRegister(instr->value()); 2313 val = UseRegister(instr->value());
2314 } 2314 }
2315 2315
2316 // We need a temporary register for write barrier of the map field. 2316 // We need a temporary register for write barrier of the map field.
2317 LOperand* temp = needs_write_barrier_for_map ? TempRegister() : NULL; 2317 LOperand* temp = needs_write_barrier_for_map ? TempRegister() : NULL;
2318 2318
2319 LInstruction* result = new(zone()) LStoreNamedField(obj, val, temp); 2319 return new(zone()) LStoreNamedField(obj, val, temp);
2320 if (!instr->access().IsExternalMemory() &&
2321 instr->field_representation().IsHeapObject() &&
2322 !instr->value()->type().IsHeapObject()) {
2323 result = AssignEnvironment(result);
2324 }
2325 return result;
2326 } 2320 }
2327 2321
2328 2322
2329 LInstruction* LChunkBuilder::DoStoreNamedGeneric(HStoreNamedGeneric* instr) { 2323 LInstruction* LChunkBuilder::DoStoreNamedGeneric(HStoreNamedGeneric* instr) {
2330 LOperand* context = UseFixed(instr->context(), cp); 2324 LOperand* context = UseFixed(instr->context(), cp);
2331 LOperand* obj = UseFixed(instr->object(), r1); 2325 LOperand* obj = UseFixed(instr->object(), r1);
2332 LOperand* val = UseFixed(instr->value(), r0); 2326 LOperand* val = UseFixed(instr->value(), r0);
2333 2327
2334 LInstruction* result = new(zone()) LStoreNamedGeneric(context, obj, val); 2328 LInstruction* result = new(zone()) LStoreNamedGeneric(context, obj, val);
2335 return MarkAsCall(result, instr); 2329 return MarkAsCall(result, instr);
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
2575 2569
2576 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2570 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2577 LOperand* object = UseRegister(instr->object()); 2571 LOperand* object = UseRegister(instr->object());
2578 LOperand* index = UseTempRegister(instr->index()); 2572 LOperand* index = UseTempRegister(instr->index());
2579 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index); 2573 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index);
2580 LInstruction* result = DefineSameAsFirst(load); 2574 LInstruction* result = DefineSameAsFirst(load);
2581 return AssignPointerMap(result); 2575 return AssignPointerMap(result);
2582 } 2576 }
2583 2577
2584 } } // namespace v8::internal 2578 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698