Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 299363003: aw: Improve DeferredGpuCommandService scheduling (Closed)

Created:
6 years, 7 months ago by boliu
Modified:
6 years, 6 months ago
Reviewers:
no sievers
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

aw: Improve DeferredGpuCommandService scheduling Simple fixes first. First if GPU thread is already executing GL, then don't schedule and just make sure the GPU flushes before finishing executing said GL. Then make sure we don't send repeated and unnecessary RequestDrawGL. BUG=344087 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273092

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -3 lines) Patch
M android_webview/browser/deferred_gpu_command_service.cc View 1 4 chunks +46 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
boliu
PTAL
6 years, 7 months ago (2014-05-27 15:11:42 UTC) #1
no sievers
https://codereview.chromium.org/299363003/diff/1/android_webview/browser/deferred_gpu_command_service.cc File android_webview/browser/deferred_gpu_command_service.cc (right): https://codereview.chromium.org/299363003/diff/1/android_webview/browser/deferred_gpu_command_service.cc#newcode21 android_webview/browser/deferred_gpu_command_service.cc:21: void set(bool boolean); nit: caps Set()/Get() https://codereview.chromium.org/299363003/diff/1/android_webview/browser/deferred_gpu_command_service.cc#newcode44 android_webview/browser/deferred_gpu_command_service.cc:44: base::LazyInstance<ThreadSafeBool> ...
6 years, 7 months ago (2014-05-27 20:12:47 UTC) #2
boliu
both done
6 years, 7 months ago (2014-05-27 20:52:30 UTC) #3
no sievers
lgtm
6 years, 7 months ago (2014-05-27 20:55:22 UTC) #4
boliu
The CQ bit was checked by boliu@chromium.org
6 years, 7 months ago (2014-05-27 21:08:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/299363003/20001
6 years, 7 months ago (2014-05-27 21:09:34 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 00:44:47 UTC) #7
Message was sent while issue was closed.
Change committed as 273092

Powered by Google App Engine
This is Rietveld 408576698