aw: Improve DeferredGpuCommandService scheduling

android_webview/browser/deferred_gpu_command_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/deferred_gpu_command_service.h"
 
 #include "android_webview/browser/gl_view_renderer_manager.h"
 #include "android_webview/browser/shared_renderer_state.h"
+#include "base/synchronization/lock.h"
 #include "content/public/browser/android/synchronous_compositor.h"
 #include "gpu/command_buffer/service/shader_translator_cache.h"
 
 namespace android_webview {
 
 namespace {
+
+// TODO(boliu): Consider using base/atomicops.h.
+class ThreadSafeBool {
+ public:
+  ThreadSafeBool();
+  void set(bool boolean);

[no sievers, 2014/05/27 20:12:48]

nit: caps Set()/Get()

+  bool get();
+
+ private:
+  base::Lock lock_;
+  bool boolean_;
+  DISALLOW_COPY_AND_ASSIGN(ThreadSafeBool);
+};
+
+ThreadSafeBool::ThreadSafeBool() : boolean_(false) {
+}
+
+void ThreadSafeBool::set(bool boolean) {
+  base::AutoLock lock(lock_);
+  boolean_ = boolean;
+}
+
+bool ThreadSafeBool::get() {
+  base::AutoLock lock(lock_);
+  return boolean_;
+}
+
+base::LazyInstance<ThreadSafeBool> g_need_schedule = LAZY_INSTANCE_INITIALIZER;
+base::LazyInstance<ThreadSafeBool> g_request_pending =

[no sievers, 2014/05/27 20:12:48]

Does it work pretty much as good if you combine the flags into one
(request_pending) and don't reset it until ~ScopedAllowGL() in order to simplify
things a bit?

It seems like the only difference is that you are in Draw while the child has
not requested a flush yet. But does that really happen?

+    LAZY_INSTANCE_INITIALIZER;
+
 base::LazyInstance<scoped_refptr<DeferredGpuCommandService> >
     g_service = LAZY_INSTANCE_INITIALIZER;
 }  // namespace
 
 base::LazyInstance<base::ThreadLocalBoolean> ScopedAllowGL::allow_gl;
 
 // static
 bool ScopedAllowGL::IsAllowed() {
   return allow_gl.Get().Get();
 }
 
+// static
+bool ScopedAllowGL::NeedSchedule() {
+  return g_need_schedule.Get().get();
+}
+
 ScopedAllowGL::ScopedAllowGL() {
   DCHECK(!allow_gl.Get().Get());
   allow_gl.Get().Set(true);
+  g_need_schedule.Get().set(false);
+  g_request_pending.Get().set(false);
 
   if (g_service.Get())
     g_service.Get()->RunTasks();
 }
 
-ScopedAllowGL::~ScopedAllowGL() { allow_gl.Get().Set(false); }
+ScopedAllowGL::~ScopedAllowGL() {
+  allow_gl.Get().Set(false);
+  g_need_schedule.Get().set(true);
+
+  if (g_service.Get())
+    g_service.Get()->RunTasks();
+}
 
 // static
 void DeferredGpuCommandService::SetInstance() {
   if (!g_service.Get()) {
     g_service.Get() = new DeferredGpuCommandService;
     content::SynchronousCompositor::SetGpuService(g_service.Get());
+    // Initialize global booleans.
+    g_request_pending.Get().set(false);
+    g_need_schedule.Get().set(true);
   }
 }
 
 // static
 DeferredGpuCommandService* DeferredGpuCommandService::GetInstance() {
   DCHECK(g_service.Get().get());
   return g_service.Get().get();
 }
 
 DeferredGpuCommandService::DeferredGpuCommandService() {}
 
 DeferredGpuCommandService::~DeferredGpuCommandService() {
   base::AutoLock lock(tasks_lock_);
   DCHECK(tasks_.empty());
 }
 
 // This method can be called on any thread.
 // static
 void DeferredGpuCommandService::RequestProcessGL() {
   SharedRendererState* renderer_state =
       GLViewRendererManager::GetInstance()->GetMostRecentlyDrawn();
   if (!renderer_state) {
     LOG(ERROR) << "No hardware renderer. Deadlock likely";
     return;
   }
-  renderer_state->ClientRequestDrawGL();
+
+  if (!g_request_pending.Get().get()) {
+    g_request_pending.Get().set(true);
+    renderer_state->ClientRequestDrawGL();
+  }
 }
 
 // Called from different threads!
 void DeferredGpuCommandService::ScheduleTask(const base::Closure& task) {
   {
     base::AutoLock lock(tasks_lock_);
     tasks_.push(task);
   }
   if (ScopedAllowGL::IsAllowed()) {
     RunTasks();
-  } else {
-    // TODO(boliu): Improve this to avoid PostTask storm.
+  } else if (ScopedAllowGL::NeedSchedule()) {
     RequestProcessGL();
   }
 }
 
 void DeferredGpuCommandService::ScheduleIdleWork(
     const base::Closure& callback) {
   // TODO(sievers): Should this do anything?
 }
 
 bool DeferredGpuCommandService::UseVirtualizedGLContexts() { return true; }
@@ skipping 29 matching lines @@
 
 void DeferredGpuCommandService::AddRef() const {
   base::RefCountedThreadSafe<DeferredGpuCommandService>::AddRef();
 }
 
 void DeferredGpuCommandService::Release() const {
   base::RefCountedThreadSafe<DeferredGpuCommandService>::Release();
 }
 
 }  // namespace android_webview