Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: Source/core/editing/ReplaceNodeWithSpanCommand.h

Issue 299353004: Oilpan: move editing objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make test wrapper class finalized Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/ReplaceNodeWithSpanCommand.h
diff --git a/Source/core/editing/ReplaceNodeWithSpanCommand.h b/Source/core/editing/ReplaceNodeWithSpanCommand.h
index 76bbcc8e8b0bd0af16c9c465f296d0d27e3dee7f..6d1f13b132b520f48e504258e7a75ed795e31cb9 100644
--- a/Source/core/editing/ReplaceNodeWithSpanCommand.h
+++ b/Source/core/editing/ReplaceNodeWithSpanCommand.h
@@ -40,21 +40,23 @@ class HTMLElement;
// More accurately, this is ReplaceElementWithSpanPreservingChildrenAndAttributesCommand
class ReplaceNodeWithSpanCommand FINAL : public SimpleEditCommand {
public:
- static PassRefPtr<ReplaceNodeWithSpanCommand> create(PassRefPtrWillBeRawPtr<HTMLElement> element)
+ static PassRefPtrWillBeRawPtr<ReplaceNodeWithSpanCommand> create(PassRefPtrWillBeRawPtr<HTMLElement> element)
{
- return adoptRef(new ReplaceNodeWithSpanCommand(element));
+ return adoptRefWillBeNoop(new ReplaceNodeWithSpanCommand(element));
}
HTMLElement* spanElement() { return m_spanElement.get(); }
+ virtual void trace(Visitor*) OVERRIDE;
+
private:
explicit ReplaceNodeWithSpanCommand(PassRefPtrWillBeRawPtr<HTMLElement>);
virtual void doApply() OVERRIDE;
virtual void doUnapply() OVERRIDE;
- RefPtrWillBePersistent<HTMLElement> m_elementToReplace;
- RefPtrWillBePersistent<HTMLElement> m_spanElement;
+ RefPtrWillBeMember<HTMLElement> m_elementToReplace;
+ RefPtrWillBeMember<HTMLElement> m_spanElement;
};
} // namespace WebCore
« no previous file with comments | « Source/core/editing/RemoveNodePreservingChildrenCommand.cpp ('k') | Source/core/editing/ReplaceNodeWithSpanCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698