Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: Source/core/editing/RemoveNodePreservingChildrenCommand.cpp

Issue 299353004: Oilpan: move editing objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make test wrapper class finalized Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/RemoveNodePreservingChildrenCommand.cpp
diff --git a/Source/core/editing/RemoveNodePreservingChildrenCommand.cpp b/Source/core/editing/RemoveNodePreservingChildrenCommand.cpp
index 977f3cc637e705095c5e3f80769b21a060fc48ff..e5c992114cd1f9049874e8f5278fdf4002daf940 100644
--- a/Source/core/editing/RemoveNodePreservingChildrenCommand.cpp
+++ b/Source/core/editing/RemoveNodePreservingChildrenCommand.cpp
@@ -31,7 +31,7 @@
namespace WebCore {
-RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand(PassRefPtr<Node> node, ShouldAssumeContentIsAlwaysEditable shouldAssumeContentIsAlwaysEditable)
+RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand(PassRefPtrWillBeRawPtr<Node> node, ShouldAssumeContentIsAlwaysEditable shouldAssumeContentIsAlwaysEditable)
: CompositeEditCommand(node->document())
, m_node(node)
, m_shouldAssumeContentIsAlwaysEditable(shouldAssumeContentIsAlwaysEditable)
@@ -41,17 +41,23 @@ RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand(PassRef
void RemoveNodePreservingChildrenCommand::doApply()
{
- Vector<RefPtr<Node> > children;
+ WillBeHeapVector<RefPtrWillBeMember<Node> > children;
for (Node* child = m_node->firstChild(); child; child = child->nextSibling())
children.append(child);
size_t size = children.size();
for (size_t i = 0; i < size; ++i) {
- RefPtr<Node> child = children[i].release();
+ RefPtrWillBeRawPtr<Node> child = children[i].release();
removeNode(child, m_shouldAssumeContentIsAlwaysEditable);
insertNodeBefore(child.release(), m_node, m_shouldAssumeContentIsAlwaysEditable);
}
removeNode(m_node, m_shouldAssumeContentIsAlwaysEditable);
}
+void RemoveNodePreservingChildrenCommand::trace(Visitor* visitor)
+{
+ visitor->trace(m_node);
+ CompositeEditCommand::trace(visitor);
+}
+
}
« no previous file with comments | « Source/core/editing/RemoveNodePreservingChildrenCommand.h ('k') | Source/core/editing/ReplaceNodeWithSpanCommand.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698