Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Unified Diff: Source/core/editing/ReplaceNodeWithSpanCommand.cpp

Issue 299353004: Oilpan: move editing objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make test wrapper class finalized Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/ReplaceNodeWithSpanCommand.h ('k') | Source/core/editing/ReplaceSelectionCommand.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/ReplaceNodeWithSpanCommand.cpp
diff --git a/Source/core/editing/ReplaceNodeWithSpanCommand.cpp b/Source/core/editing/ReplaceNodeWithSpanCommand.cpp
index a682948a5142b5c64f38b24cc30ae4c8a3fee7a7..5fde26426624b41cd662c9208e7cee82f7de4575 100644
--- a/Source/core/editing/ReplaceNodeWithSpanCommand.cpp
+++ b/Source/core/editing/ReplaceNodeWithSpanCommand.cpp
@@ -51,7 +51,7 @@ ReplaceNodeWithSpanCommand::ReplaceNodeWithSpanCommand(PassRefPtrWillBeRawPtr<HT
static void swapInNodePreservingAttributesAndChildren(HTMLElement* newNode, HTMLElement& nodeToReplace)
{
ASSERT(nodeToReplace.inDocument());
- RefPtr<ContainerNode> parentNode = nodeToReplace.parentNode();
+ RefPtrWillBeRawPtr<ContainerNode> parentNode = nodeToReplace.parentNode();
parentNode->insertBefore(newNode, &nodeToReplace);
NodeVector children;
@@ -81,4 +81,11 @@ void ReplaceNodeWithSpanCommand::doUnapply()
swapInNodePreservingAttributesAndChildren(m_elementToReplace.get(), *m_spanElement);
}
+void ReplaceNodeWithSpanCommand::trace(Visitor* visitor)
+{
+ visitor->trace(m_elementToReplace);
+ visitor->trace(m_spanElement);
+ SimpleEditCommand::trace(visitor);
+}
+
} // namespace WebCore
« no previous file with comments | « Source/core/editing/ReplaceNodeWithSpanCommand.h ('k') | Source/core/editing/ReplaceSelectionCommand.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698