Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2993523002: swarming: round OSX temperature readings to 2 digits, trim sensor readings (Closed)

Created:
3 years, 4 months ago by M-A Ruel
Modified:
3 years, 4 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, Ken Russell (switch to Gerrit)
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

swarming: round OSX temperature readings to 2 digits, trim sensor readings - Some sensor readings had too much precision. It's not useful to have more precision than 2 fractional digits, since the sensors are likely not as accurate anyway. - Renamed 'cpu0 proximity' to 'cpu0'. - Renamed the two 'power supply' to be able to figure out which of the two is useful. A follow up CL will clean this out specifically. - Commented out most sensors, including the gpu0 ones. - Keep the sensors that looked potentially most useful from making the previous code live on production. Here's what will be kept with what is currently advertized by each hardware platform: MacBookAir7,1: cpu0, enclosure bottom (build125-b1) MacBookPro11,3: cpu0, enclosure bottom (build101-b1) MacPro6,1: ambient, cpu0 (build11-m4) Macmini5,3: ambient, cpu0, power supply (build12-b1) Macmini7,1: ambient, cpu0, power supply (build186-m4) R=vadimsh@chromium.org BUG=749840 Review-Url: https://codereview.chromium.org/2993523002 Committed: https://github.com/luci/luci-py/commit/a5bd199073d6032880cd9d268cc47b0a59689ea7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -88 lines) Patch
M appengine/swarming/swarming_bot/api/platforms/osx.py View 2 chunks +91 lines, -88 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
M-A Ruel
3 years, 4 months ago (2017-08-01 15:17:34 UTC) #3
Vadim Sh.
lgtm
3 years, 4 months ago (2017-08-01 16:39:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2993523002/1
3 years, 4 months ago (2017-08-01 16:53:21 UTC) #6
commit-bot: I haz the power
3 years, 4 months ago (2017-08-01 16:57:33 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/a5bd199073d6032880cd9d268cc47b0a59689ea7

Powered by Google App Engine
This is Rietveld 408576698