Re-create devtools client upon browser restart

Re-create devtools client upon browser restart
(cros guest session did a browser restart without recreating the dev tools backend).

BUG=chromium:753116
Review-Url: https://codereview.chromium.org/2993363002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/bd05965e45572ae06d1a7139759a85a3d9a1a27c

[pfeldman, 2017-08-09 21:12:33]

pfeldman@chromium.org changed reviewers:
+ achuith@chromium.org, nednguyen@google.com

[pfeldman, 2017-08-09 21:28:41]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-09 21:28:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[achuithb, 2017-08-09 21:28:49]

The CQ bit was checked by achuith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-09 21:28:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[achuithb, 2017-08-09 21:32:48]

lgtm

https://codereview.chromium.org/2993363002/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py
(right):

https://codereview.chromium.org/2993363002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py:143: """
Wait for browser to come up.
Let's add a comment here saying that we're also creating the devtools client
backend. 

I'm not sure _WaitForBrowserToComeUp is still a good name for this function now
that it has this side effect of initing DevToolsClientBackend. I'm fine with
this, but Ned may have a suggestion for a better name.

[achuithb, 2017-08-09 21:35:48]

Please expand the commit message to explain that cros guest session does a
browser restart without recreating the dev tools backend.

[pfeldman, 2017-08-09 21:44:24]

Description was changed from

==========
Re-create devtools client upon browser restart

BUG=chromium:753116
==========

to

==========
Re-create devtools client upon browser restart
(cros guest session did a browser restart without recreating the dev tools
backend).

BUG=chromium:753116
==========

[pfeldman, 2017-08-09 21:46:20]

https://codereview.chromium.org/2993363002/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py
(right):

https://codereview.chromium.org/2993363002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py:143: """
Wait for browser to come up.
I think it is fine for client creation to be a by product of the browser
startup, that's how we connect to it anyways. It is actually beneficial to have
this creation being an implementation detail rather than being explicitly
invoked. Unless we have reasons to believe that we will have 
_WaitForBrowserToComeUp with no connection in the future.

[achuithb, 2017-08-09 21:53:26]

https://codereview.chromium.org/2993363002/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py
(right):

https://codereview.chromium.org/2993363002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py:143: """
Wait for browser to come up.
On 2017/08/09 21:46:19, pfeldman wrote:
> I think it is fine for client creation to be a by product of the browser
> startup, that's how we connect to it anyways. It is actually beneficial to
have
> this creation being an implementation detail rather than being explicitly
> invoked. Unless we have reasons to believe that we will have 
> _WaitForBrowserToComeUp with no connection in the future.

Acknowledged.

Makes sense to me - let's see if Ned has an opinion.

[commit-bot: I haz the power, 2017-08-09 21:55:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-09 21:55:35]

Dry run: This issue passed the CQ dry run.

[nednguyen, 2017-08-09 23:02:32]

lgtm

Thanks for making this less error prone!

[pfeldman, 2017-08-09 23:05:56]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2017-08-09 23:06:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-09 23:07:47]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1502319956345380, "parent_rev":
"1a9b732fc4f9de894c8636ee9ed5361b76fa9eb8", "commit_rev":
"bd05965e45572ae06d1a7139759a85a3d9a1a27c"}

[commit-bot: I haz the power, 2017-08-09 23:07:52]

Description was changed from

==========
Re-create devtools client upon browser restart
(cros guest session did a browser restart without recreating the dev tools
backend).

BUG=chromium:753116
==========

to

==========
Re-create devtools client upon browser restart
(cros guest session did a browser restart without recreating the dev tools
backend).

BUG=chromium:753116

Review-Url: https://codereview.chromium.org/2993363002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-08-09 23:07:53]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...