telemetry/telemetry/internal/backends/chrome/android_browser_backend.py - Issue 2993363002: Re-create devtools client upon browser restart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/backends/chrome/android_browser_backend.py

Issue 2993363002: Re-create devtools client upon browser restart (Closed)

Patch Set: Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py » ('j') | telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/backends/chrome/android_browser_backend.py

diff --git a/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py b/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py

index 4f7a2004e2735edf7e7c4b2415d9834ef477ba17..5a21d8e179987f61a5edf55e63831d935dc3cabd 100644

--- a/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py

+++ b/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py

@@ -151,8 +151,7 @@ class AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

raise

try:

- self._WaitForBrowserToComeUp()

- self._InitDevtoolsClientBackend(remote_devtools_port)

+ self._WaitForBrowserToComeUp(remote_devtools_port)

except exceptions.BrowserGoneException:

logging.critical('Failed to connect to browser.')

if not (self.device.HasRoot() or self.device.NeedsSU()):