[vm] Several unit tests are corrected for limited ints

[vm] Several unit tests are corrected for limited ints

This CL corrects several unit tests to work in --limit-ints-to-64-bits
mode: without built-in Bigints and with wrap-around 64-bit Dart
integers.

R=zra@google.com

Issue: https://github.com/dart-lang/sdk/issues/30103
Committed: https://github.com/dart-lang/sdk/commit/62bbd4895d27aa5efc57ec8910bb37d83b4041a9

[alexmarkov, 2017-07-31 23:35:18]

alexmarkov@google.com changed reviewers:
+ asiva@google.com, zra@google.com

[alexmarkov, 2017-07-31 23:35:18]

https://codereview.chromium.org/2992093002/diff/1/runtime/vm/dart_api_impl_te...
File runtime/vm/dart_api_impl_test.cc (right):

https://codereview.chromium.org/2992093002/diff/1/runtime/vm/dart_api_impl_te...
runtime/vm/dart_api_impl_test.cc:5343: EXPECT(arg_values[2].as_uint64 ==
0x8000000000000000LL);
Note: this particular value is chosen for the following reasons.
1) When wrapped-around, it should not fit into int32, because this unit test
verifies that getting it as int32 produces error. The original value MaxUint64
does not work for this reason, as it wraps around to -1.
2) It should be large enough to exercise Bigints with unlimited ints, so it
should be > MaxInt64.
Given these constraints, any value between MaxInt64+1 and MaxUint64-MaxInt32-1
would work. Value 0x8000000000000000 is in this range and easy to produce
without using a large integer literal.

[zra, 2017-08-01 16:13:50]

lgtm

https://codereview.chromium.org/2992093002/diff/1/runtime/vm/dart_api_impl_te...
File runtime/vm/dart_api_impl_test.cc (right):

https://codereview.chromium.org/2992093002/diff/1/runtime/vm/dart_api_impl_te...
runtime/vm/dart_api_impl_test.cc:5343: EXPECT(arg_values[2].as_uint64 ==
0x8000000000000000LL);
On 2017/07/31 23:35:18, alexmarkov wrote:
> Note: this particular value is chosen for the following reasons.
> 1) When wrapped-around, it should not fit into int32, because this unit test
> verifies that getting it as int32 produces error. The original value MaxUint64
> does not work for this reason, as it wraps around to -1.
> 2) It should be large enough to exercise Bigints with unlimited ints, so it
> should be > MaxInt64.
> Given these constraints, any value between MaxInt64+1 and MaxUint64-MaxInt32-1
> would work. Value 0x8000000000000000 is in this range and easy to produce
> without using a large integer literal.

I think this would be good to add as a comment in the code.

[alexmarkov, 2017-08-01 16:25:43]

https://codereview.chromium.org/2992093002/diff/1/runtime/vm/dart_api_impl_te...
File runtime/vm/dart_api_impl_test.cc (right):

https://codereview.chromium.org/2992093002/diff/1/runtime/vm/dart_api_impl_te...
runtime/vm/dart_api_impl_test.cc:5343: EXPECT(arg_values[2].as_uint64 ==
0x8000000000000000LL);
On 2017/08/01 16:13:49, zra wrote:
> On 2017/07/31 23:35:18, alexmarkov wrote:
> > Note: this particular value is chosen for the following reasons.
> > 1) When wrapped-around, it should not fit into int32, because this unit test
> > verifies that getting it as int32 produces error. The original value
MaxUint64
> > does not work for this reason, as it wraps around to -1.
> > 2) It should be large enough to exercise Bigints with unlimited ints, so it
> > should be > MaxInt64.
> > Given these constraints, any value between MaxInt64+1 and
MaxUint64-MaxInt32-1
> > would work. Value 0x8000000000000000 is in this range and easy to produce
> > without using a large integer literal.
> 
> I think this would be good to add as a comment in the code.

Done.

[alexmarkov, 2017-08-01 16:29:15]

Description was changed from

==========
[vm] Several unit tests are corrected for limited ints

This CL corrects several unit tests to work in --limit-ints-to-64-bits
mode: without built-in Bigints and with wrap-around 64-bit Dart
integers.

Issue: https://github.com/dart-lang/sdk/issues/30103
==========

to

==========
[vm] Several unit tests are corrected for limited ints

This CL corrects several unit tests to work in --limit-ints-to-64-bits
mode: without built-in Bigints and with wrap-around 64-bit Dart
integers.

R=zra@google.com

Issue: https://github.com/dart-lang/sdk/issues/30103
Committed:
https://github.com/dart-lang/sdk/commit/62bbd4895d27aa5efc57ec8910bb37d83b4041a9
==========

[alexmarkov, 2017-08-01 16:29:16]

Committed patchset #2 (id:20001) manually as
62bbd4895d27aa5efc57ec8910bb37d83b4041a9 (presubmit successful).