[vm] Several unit tests are corrected for limited ints

runtime/vm/dart_api_impl_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/dart_api_impl.h"
 #include "bin/builtin.h"
 #include "include/dart_api.h"
 #include "include/dart_mirrors_api.h"
 #include "include/dart_native_api.h"
 #include "include/dart_tools_api.h"
@@ skipping 5322 matching lines @@
     arg_values[7].as_native_fields.values = native_fields2;
     Dart_Handle result =
         Dart_GetNativeArguments(args, 9, arg_descriptors, arg_values);
     EXPECT_VALID(result);
 
     EXPECT(arg_values[0].as_native_fields.values[0] == 30);
     EXPECT(arg_values[0].as_native_fields.values[1] == 40);
 
     EXPECT(arg_values[1].as_int32 == 77);
 
-    EXPECT(arg_values[2].as_uint64 == 0xffffffffffffffffLL);
+    EXPECT(arg_values[2].as_uint64 == 0x8000000000000000LL);

[alexmarkov, 2017/07/31 23:35:18]

Note: this particular value is chosen for the following reasons.
1) When wrapped-around, it should not fit into int32, because this unit test
verifies that getting it as int32 produces error. The original value MaxUint64
does not work for this reason, as it wraps around to -1.
2) It should be large enough to exercise Bigints with unlimited ints, so it
should be > MaxInt64.
Given these constraints, any value between MaxInt64+1 and MaxUint64-MaxInt32-1
would work. Value 0x8000000000000000 is in this range and easy to produce
without using a large integer literal.

[zra, 2017/08/01 16:13:49]

I think this would be good to add as a comment in the code.

[alexmarkov, 2017/08/01 16:25:43]

Done.

 
     EXPECT(arg_values[3].as_bool == true);
 
     EXPECT(arg_values[4].as_double == 3.14);
 
     EXPECT_VALID(arg_values[5].as_string.dart_str);
     EXPECT(Dart_IsString(arg_values[5].as_string.dart_str));
     EXPECT_VALID(Dart_StringToCString(arg_values[5].as_string.dart_str, &cstr));
     EXPECT_STREQ("abcdefg", cstr);
     EXPECT(arg_values[5].as_string.peer == NULL);
@@ skipping 85 matching lines @@
       "                   double arg4,"
       "                   String arg5,"
       "                   String arg6,"
       "                   MyObject arg7) native 'NativeArgument_Access';"
       "}"
       "int testMain(String extstr) {"
       "  String str = 'abcdefg';"
       "  MyObject obj1 = MyObject.createObject();"
       "  MyObject obj2 = MyObject.createObject();"
       "  return obj1.accessFields(77,"
-      "                           0xffffffffffffffff,"
+      "                           1 << 63,"
       "                           true,"
       "                           3.14,"
       "                           str,"
       "                           extstr,"
       "                           obj2);"
       "}";
 
   Dart_Handle lib = TestCase::LoadTestScript(
       kScriptChars,
       reinterpret_cast<Dart_NativeEntryResolver>(native_args_lookup));
@@ skipping 4162 matching lines @@
   EXPECT_VALID(result);
   result = Dart_FinalizeLoading(false);
   EXPECT_VALID(result);
   result = Dart_Invoke(lib, NewString("foozoo"), 0, NULL);
   EXPECT(Dart_IsError(result));
 }
 
 #endif  // !PRODUCT
 
 }  // namespace dart