[vm] Several unit tests are corrected for limited ints

runtime/vm/snapshot_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 
 #include "include/dart_tools_api.h"
 #include "platform/assert.h"
 #include "vm/class_finalizer.h"
 #include "vm/clustered_snapshot.h"
@@ skipping 1837 matching lines @@
 
   // Read object back from the snapshot into a C structure.
   ApiNativeScope scope;
   ApiMessageReader api_reader(buffer, buffer_len);
   Dart_CObject* root = api_reader.ReadMessage();
   EXPECT_NOTNULL(root);
   EXPECT_EQ(Dart_CObject_kUnsupported, root->type);
 }
 
 VM_UNIT_TEST_CASE(DartGeneratedMessages) {
-  static const char* kCustomIsolateScriptChars =
+  static const char* kCustomIsolateScriptCommonChars =
       "getSmi() {\n"
       "  return 42;\n"
       "}\n"
-      "getBigint() {\n"
-      "  return -0x424242424242424242424242424242424242;\n"
-      "}\n"
       "getAsciiString() {\n"
       "  return \"Hello, world!\";\n"
       "}\n"
       "getNonAsciiString() {\n"
       "  return \"Blåbærgrød\";\n"
       "}\n"
       "getNonBMPString() {\n"
       "  return \"\\u{10000}\\u{1F601}\\u{1F637}\\u{20000}\";\n"
       "}\n"
       "getLeadSurrogateString() {\n"
       "  return new String.fromCharCodes([0xd800]);\n"
       "}\n"
       "getTrailSurrogateString() {\n"
       "  return \"\\u{10000}\".substring(1);\n"
       "}\n"
       "getSurrogatesString() {\n"
       "  return new String.fromCharCodes([0xdc00, 0xdc00, 0xd800, 0xd800]);\n"
       "}\n"
       "getCrappyString() {\n"
       "  return new String.fromCharCodes([0xd800, 32, 0xdc00, 32]);\n"
       "}\n"
       "getList() {\n"
       "  return new List(kArrayLength);\n"
       "}\n";
+  static const char* kCustomIsolateScriptBigintChars =
+      "getBigint() {\n"
+      "  return -0x424242424242424242424242424242424242;\n"
+      "}\n";
 
   TestCase::CreateTestIsolate();
   Isolate* isolate = Isolate::Current();
   EXPECT(isolate != NULL);
   Dart_EnterScope();
 
-  Dart_Handle lib = TestCase::LoadTestScript(kCustomIsolateScriptChars, NULL);
+  const char* scriptChars = kCustomIsolateScriptCommonChars;
+  if (!Bigint::IsDisabled()) {
+    scriptChars = OS::SCreate(Thread::Current()->zone(), "%s%s", scriptChars,
+                              kCustomIsolateScriptBigintChars);
+  }
+
+  Dart_Handle lib = TestCase::LoadTestScript(scriptChars, NULL);
   EXPECT_VALID(lib);
   Dart_Handle smi_result;
   smi_result = Dart_Invoke(lib, NewString("getSmi"), 0, NULL);
   EXPECT_VALID(smi_result);
-  Dart_Handle bigint_result;
-  bigint_result = Dart_Invoke(lib, NewString("getBigint"), 0, NULL);
-  EXPECT_VALID(bigint_result);
+
+  Dart_Handle bigint_result = NULL;
+  if (!Bigint::IsDisabled()) {
+    bigint_result = Dart_Invoke(lib, NewString("getBigint"), 0, NULL);
+    EXPECT_VALID(bigint_result);
+  }
 
   Dart_Handle ascii_string_result;
   ascii_string_result = Dart_Invoke(lib, NewString("getAsciiString"), 0, NULL);
   EXPECT_VALID(ascii_string_result);
   EXPECT(Dart_IsString(ascii_string_result));
 
   Dart_Handle non_ascii_string_result;
   non_ascii_string_result =
       Dart_Invoke(lib, NewString("getNonAsciiString"), 0, NULL);
   EXPECT_VALID(non_ascii_string_result);
@@ skipping 45 matching lines @@
 
       // Read object back from the snapshot into a C structure.
       ApiNativeScope scope;
       ApiMessageReader api_reader(buffer, buffer_len);
       Dart_CObject* root = api_reader.ReadMessage();
       EXPECT_NOTNULL(root);
       EXPECT_EQ(Dart_CObject_kInt32, root->type);
       EXPECT_EQ(42, root->value.as_int32);
       CheckEncodeDecodeMessage(root);
     }
-    {
+    if (!Bigint::IsDisabled()) {
       StackZone zone(thread);
       Bigint& bigint = Bigint::Handle();
       bigint ^= Api::UnwrapHandle(bigint_result);
       uint8_t* buffer;
       MessageWriter writer(&buffer, &zone_allocator, &zone_deallocator, false);
       writer.WriteMessage(bigint);
       intptr_t buffer_len = writer.BytesWritten();
 
       // Read object back from the snapshot into a C structure.
       ApiNativeScope scope;
@@ skipping 347 matching lines @@
         EXPECT_EQ(i + 1, e->value.as_int32);
       }
     }
   }
   Dart_ExitScope();
   Dart_ShutdownIsolate();
 }
 
 VM_UNIT_TEST_CASE(DartGeneratedListMessagesWithBackref) {
   const int kArrayLength = 10;
-  static const char* kScriptChars =
+  static const char* kScriptCommonChars =
       "import 'dart:typed_data';\n"
       "final int kArrayLength = 10;\n"
       "getStringList() {\n"
       "  var s = 'Hello, world!';\n"
       "  var list = new List<String>(kArrayLength);\n"
       "  for (var i = 0; i < kArrayLength; i++) list[i] = s;\n"
       "  return list;\n"
       "}\n"
       "getMintList() {\n"
       "  var mint = 0x7FFFFFFFFFFFFFFF;\n"
       "  var list = new List(kArrayLength);\n"
       "  for (var i = 0; i < kArrayLength; i++) list[i] = mint;\n"
       "  return list;\n"
       "}\n"
-      "getBigintList() {\n"
-      "  var bigint = 0x1234567890123456789012345678901234567890;\n"
-      "  var list = new List(kArrayLength);\n"
-      "  for (var i = 0; i < kArrayLength; i++) list[i] = bigint;\n"
-      "  return list;\n"
-      "}\n"
       "getDoubleList() {\n"
       "  var d = 3.14;\n"
       "  var list = new List<double>(kArrayLength);\n"
       "  for (var i = 0; i < kArrayLength; i++) list[i] = d;\n"
       "  return list;\n"
       "}\n"
       "getTypedDataList() {\n"
       "  var byte_array = new Uint8List(256);\n"
       "  var list = new List(kArrayLength);\n"
       "  for (var i = 0; i < kArrayLength; i++) list[i] = byte_array;\n"
@@ skipping 15 matching lines @@
       "  }\n"
       "  return list;\n"
       "}\n"
       "getSelfRefList() {\n"
       "  var list = new List(kArrayLength);\n"
       "  for (var i = 0; i < kArrayLength; i++) {\n"
       "    list[i] = list;\n"
       "  }\n"
       "  return list;\n"
       "}\n";
+  static const char* kScriptBigintChars =
+      "getBigintList() {\n"
+      "  var bigint = 0x1234567890123456789012345678901234567890;\n"
+      "  var list = new List(kArrayLength);\n"
+      "  for (var i = 0; i < kArrayLength; i++) list[i] = bigint;\n"
+      "  return list;\n"
+      "}\n";
 
   TestCase::CreateTestIsolate();
   Thread* thread = Thread::Current();
   EXPECT(thread->isolate() != NULL);
   Dart_EnterScope();
 
-  Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
+  const char* scriptChars = kScriptCommonChars;
+  if (!Bigint::IsDisabled()) {
+    scriptChars =
+        OS::SCreate(thread->zone(), "%s%s", scriptChars, kScriptBigintChars);
+  }
+
+  Dart_Handle lib = TestCase::LoadTestScript(scriptChars, NULL);
   EXPECT_VALID(lib);
 
   {
     CHECK_API_SCOPE(thread);
     HANDLESCOPE(thread);
     StackZone zone(thread);
     intptr_t buf_len = 0;
     {
       // Generate a list of strings from Dart code.
       uint8_t* buf = GetSerialized(lib, "getStringList", &buf_len);
@@ skipping 17 matching lines @@
       EXPECT_NOTNULL(root);
       EXPECT_EQ(Dart_CObject_kArray, root->type);
       EXPECT_EQ(kArrayLength, root->value.as_array.length);
       for (int i = 0; i < kArrayLength; i++) {
         Dart_CObject* element = root->value.as_array.values[i];
         EXPECT_EQ(root->value.as_array.values[0], element);
         EXPECT_EQ(Dart_CObject_kInt64, element->type);
         EXPECT_EQ(DART_INT64_C(0x7FFFFFFFFFFFFFFF), element->value.as_int64);
       }
     }
-    {
+    if (!Bigint::IsDisabled()) {
       // Generate a list of bigints from Dart code.
       uint8_t* buf = GetSerialized(lib, "getBigintList", &buf_len);
       ApiNativeScope scope;
       Dart_CObject* root = GetDeserialized(buf, buf_len);
       EXPECT_NOTNULL(root);
       EXPECT_EQ(Dart_CObject_kArray, root->type);
       EXPECT_EQ(kArrayLength, root->value.as_array.length);
       for (int i = 0; i < kArrayLength; i++) {
         Dart_CObject* element = root->value.as_array.values[i];
         EXPECT_EQ(root->value.as_array.values[0], element);
@@ skipping 98 matching lines @@
         EXPECT_EQ(root, element);
       }
     }
   }
   Dart_ExitScope();
   Dart_ShutdownIsolate();
 }
 
 VM_UNIT_TEST_CASE(DartGeneratedArrayLiteralMessagesWithBackref) {
   const int kArrayLength = 10;
-  static const char* kScriptChars =
+  static const char* kScriptCommonChars =
       "import 'dart:typed_data';\n"
       "final int kArrayLength = 10;\n"
       "getStringList() {\n"
       "  var s = 'Hello, world!';\n"
       "  var list = [s, s, s, s, s, s, s, s, s, s];\n"
       "  return list;\n"
       "}\n"
       "getMintList() {\n"
       "  var mint = 0x7FFFFFFFFFFFFFFF;\n"
       "  var list = [mint, mint, mint, mint, mint,\n"
       "              mint, mint, mint, mint, mint];\n"
       "  return list;\n"
       "}\n"
-      "getBigintList() {\n"
-      "  var bigint = 0x1234567890123456789012345678901234567890;\n"
-      "  var list = [bigint, bigint, bigint, bigint, bigint,\n"
-      "              bigint, bigint, bigint, bigint, bigint];\n"
-      "  return list;\n"
-      "}\n"
       "getDoubleList() {\n"
       "  var d = 3.14;\n"
       "  var list = [3.14, 3.14, 3.14, 3.14, 3.14, 3.14];\n"
       "  list.add(3.14);\n"
       "  list.add(3.14);\n"
       "  list.add(3.14);\n"
       "  list.add(3.14);\n"
       "  return list;\n"
       "}\n"
       "getTypedDataList() {\n"
@@ skipping 22 matching lines @@
       "  }\n"
       "  return list;\n"
       "}\n"
       "getSelfRefList() {\n"
       "  var list = [];\n"
       "  for (var i = 0; i < kArrayLength; i++) {\n"
       "    list.add(list);\n"
       "  }\n"
       "  return list;\n"
       "}\n";
+  static const char* kScriptBigintChars =
+      "getBigintList() {\n"
+      "  var bigint = 0x1234567890123456789012345678901234567890;\n"
+      "  var list = [bigint, bigint, bigint, bigint, bigint,\n"
+      "              bigint, bigint, bigint, bigint, bigint];\n"
+      "  return list;\n"
+      "}\n";
 
   TestCase::CreateTestIsolate();
   Thread* thread = Thread::Current();
   EXPECT(thread->isolate() != NULL);
   Dart_EnterScope();
 
-  Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
+  const char* scriptChars = kScriptCommonChars;
+  if (!Bigint::IsDisabled()) {
+    scriptChars =
+        OS::SCreate(thread->zone(), "%s%s", scriptChars, kScriptBigintChars);
+  }
+  Dart_Handle lib = TestCase::LoadTestScript(scriptChars, NULL);
   EXPECT_VALID(lib);
 
   {
     CHECK_API_SCOPE(thread);
     HANDLESCOPE(thread);
     StackZone zone(thread);
     intptr_t buf_len = 0;
     {
       // Generate a list of strings from Dart code.
       uint8_t* buf = GetSerialized(lib, "getStringList", &buf_len);
@@ skipping 17 matching lines @@
       EXPECT_NOTNULL(root);
       EXPECT_EQ(Dart_CObject_kArray, root->type);
       EXPECT_EQ(kArrayLength, root->value.as_array.length);
       for (int i = 0; i < kArrayLength; i++) {
         Dart_CObject* element = root->value.as_array.values[i];
         EXPECT_EQ(root->value.as_array.values[0], element);
         EXPECT_EQ(Dart_CObject_kInt64, element->type);
         EXPECT_EQ(DART_INT64_C(0x7FFFFFFFFFFFFFFF), element->value.as_int64);
       }
     }
-    {
+    if (!Bigint::IsDisabled()) {
       // Generate a list of bigints from Dart code.
       uint8_t* buf = GetSerialized(lib, "getBigintList", &buf_len);
       ApiNativeScope scope;
       Dart_CObject* root = GetDeserialized(buf, buf_len);
       EXPECT_NOTNULL(root);
       EXPECT_EQ(Dart_CObject_kArray, root->type);
       EXPECT_EQ(kArrayLength, root->value.as_array.length);
       for (int i = 0; i < kArrayLength; i++) {
         Dart_CObject* element = root->value.as_array.values[i];
         EXPECT_EQ(root->value.as_array.values[0], element);
@@ skipping 397 matching lines @@
   StackZone zone(Thread::Current());
   uint8_t* buffer;
   MessageWriter writer(&buffer, &zone_allocator, &zone_deallocator, true);
   writer.WriteInlinedObjectHeader(kOmittedObjectId);
   // For performance, we'd like single-byte headers when ids are omitted.
   // If this starts failing, consider renumbering the snapshot ids.
   EXPECT_EQ(1, writer.BytesWritten());
 }
 
 }  // namespace dart