Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2991503002: isolate: Finalize the isolate in UploadTracker (Closed)

Created:
3 years, 5 months ago by mcgreevy
Modified:
3 years, 5 months ago
Reviewers:
mithro
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -45 lines) Patch
M client/cmd/isolate/exp_archive.go View 3 chunks +2 lines, -40 lines 0 comments Download
M client/cmd/isolate/upload_tracker.go View 3 chunks +51 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
mcgreevy
3 years, 5 months ago (2017-07-24 06:24:57 UTC) #2
mithro
Are there any tests for this code?
3 years, 5 months ago (2017-07-24 06:29:59 UTC) #3
mcgreevy
On 2017/07/24 06:29:59, mithro wrote: > Are there any tests for this code? Nope. I'll ...
3 years, 5 months ago (2017-07-24 06:39:29 UTC) #4
mithro
As discussed in person, mcgreevy@ will add tests in another CL as it requires some ...
3 years, 5 months ago (2017-07-24 07:05:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2991503002/1
3 years, 5 months ago (2017-07-26 04:30:24 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-07-26 04:36:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/f4e9bd5ac290f75fb9c40babee6781d741ce4f3c

Powered by Google App Engine
This is Rietveld 408576698