Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1164)

Issue 2990503002: isolate: move creation of isolate into UploadTracker (Closed)

Created:
3 years, 5 months ago by mcgreevy
Modified:
3 years, 4 months ago
Reviewers:
mithro
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -31 lines) Patch
M client/cmd/isolate/exp_archive.go View 1 chunk +2 lines, -23 lines 0 comments Download
M client/cmd/isolate/upload_tracker.go View 7 chunks +41 lines, -8 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
mcgreevy
3 years, 5 months ago (2017-07-24 06:28:01 UTC) #2
mcgreevy
looks like I missed this one when sending out cls the other day.
3 years, 5 months ago (2017-07-26 01:18:21 UTC) #3
mithro
LGTM.
3 years, 5 months ago (2017-07-26 01:33:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2990503002/1
3 years, 5 months ago (2017-07-26 02:09:35 UTC) #6
commit-bot: I haz the power
3 years, 4 months ago (2017-07-26 02:16:55 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/4f004b9af0db26e6b30b6b4ed835f0949176d12a

Powered by Google App Engine
This is Rietveld 408576698