Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2991413002: tokenserver: Implement MintOAuthTokenGrant RPC. (Closed)

Created:
3 years, 4 months ago by Vadim Sh.
Modified:
3 years, 4 months ago
Reviewers:
smut
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

tokenserver: Implement MintOAuthTokenGrant RPC. Most of it anyway. Lacks logging to BigQuery. R=smut@google.com BUG=731843 Review-Url: https://codereview.chromium.org/2991413002 Committed: https://github.com/luci/luci-go/commit/ddc861e154feb36e78c0b7b0784cacfab6414f70

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+507 lines, -1 line) Patch
A tokenserver/appengine/impl/serviceaccounts/grant.go View 1 chunk +51 lines, -0 lines 1 comment Download
A tokenserver/appengine/impl/serviceaccounts/grant_test.go View 1 chunk +86 lines, -0 lines 0 comments Download
M tokenserver/appengine/impl/serviceaccounts/rpc_mint_oauth_token_grant.go View 1 chunk +189 lines, -1 line 1 comment Download
A tokenserver/appengine/impl/serviceaccounts/rpc_mint_oauth_token_grant_test.go View 1 chunk +177 lines, -0 lines 0 comments Download
M tokenserver/appengine/impl/services/minter/tokenminter/service.go View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (3 generated)
Vadim Sh.
PTAL I'm just parroting rpc_mint_delegation_token.go implementation. I extracted reusable code (policy.Policy stuff, tokensigning.Signer, revocation.GenerateTokenID) few ...
3 years, 4 months ago (2017-08-04 06:37:38 UTC) #1
smut
lgtm
3 years, 4 months ago (2017-08-04 23:18:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2991413002/1
3 years, 4 months ago (2017-08-04 23:52:15 UTC) #4
commit-bot: I haz the power
3 years, 4 months ago (2017-08-04 23:56:51 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/ddc861e154feb36e78c0b7b0784cacfab6414f70

Powered by Google App Engine
This is Rietveld 408576698