Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 2991253002: Revert of Disable hover state change for touch event on page with viewport meta and mobile. (Closed)

Created:
3 years, 4 months ago by chaopeng
Modified:
3 years, 4 months ago
Reviewers:
bokan
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable hover state change for touch event on page with viewport meta and mobile. (patchset #5 id:80001 of https://codereview.chromium.org/2931433002/ ) Reason for revert: Revert for some website break. Original issue's description: > Disable hover state change for touch event on page with viewport meta and mobile. > > This patch prevent hover state change for touch event on mobile. > > We have 2 checks for this: > 1. Event is from touch. > 2. Viewport enabled (on mobile). > 3. Page with viewport meta. > > BUG=369044 > Review-Url: https://codereview.chromium.org/2931433002 > Cr-Commit-Position: refs/heads/master@{#478777} > Committed: https://chromium.googlesource.com/chromium/src/+/876bb220728d85b1c8a8fe93a0a95bafcf448cd6 TBR=bokan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=369044 Review-Url: https://codereview.chromium.org/2991253002 Cr-Commit-Position: refs/heads/master@{#491491} Committed: https://chromium.googlesource.com/chromium/src/+/1b85da5fda6bf34ed8abca55d39fe7371608b8b1

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -102 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 chunks +2 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/exported/WebFrameTest.cpp View 1 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/WebKit/Source/core/testing/data/noviewport-2-div.html View 1 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/Source/core/testing/data/viewport-2-div.html View 1 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
chaopeng
Created Revert of Disable hover state change for touch event on page with viewport meta ...
3 years, 4 months ago (2017-08-02 16:24:39 UTC) #1
bokan
lgtm
3 years, 4 months ago (2017-08-02 16:27:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2991253002/130001
3 years, 4 months ago (2017-08-02 19:46:27 UTC) #8
commit-bot: I haz the power
3 years, 4 months ago (2017-08-02 20:55:33 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:130001) as
https://chromium.googlesource.com/chromium/src/+/1b85da5fda6bf34ed8abca55d39f...

Powered by Google App Engine
This is Rietveld 408576698