Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2991253002: Revert of Disable hover state change for touch event on page with viewport meta and mobile. (Closed)
Patch Set: update Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/exported/WebFrameTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index a705795626d43ba6bc8000632250189345ff632d..51ba9082bf6f00d39af258d4f745fa56b3a50465 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -6550,11 +6550,6 @@ void Document::UpdateActiveState(const HitTestRequest& request,
void Document::UpdateHoverState(const HitTestRequest& request,
Element* inner_element_in_document) {
- // Do not set hover state if event is from touch and on mobile.
- bool allow_hover_changes =
- !(request.TouchEvent() && GetPage() &&
- GetPage()->GetVisualViewport().ShouldDisableDesktopWorkarounds());
-
Element* old_hover_element = HoverElement();
// The passed in innerElement may not be a result of a hit test for the
@@ -6565,10 +6560,9 @@ void Document::UpdateHoverState(const HitTestRequest& request,
SkipDisplayNoneAncestors(inner_element_in_document);
// Update our current hover element.
- if (allow_hover_changes)
- SetHoverElement(new_hover_element);
+ SetHoverElement(new_hover_element);
- if (old_hover_element == new_hover_element || !allow_hover_changes)
+ if (old_hover_element == new_hover_element)
return;
Node* ancestor_element = nullptr;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/exported/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698